Comments (3)
Although... with hindsight. The rationale behind the lack of an async context manager for User objects seems a little nonsensical, the following situation could be possible:
async with User.from_token(client, token) as user:
...
# Or alternatively
async with client.user_from_token(token) as user:
...
I think I'll add this and roll a new release by the end of today to address this lopsided design.
from spotify.py.
Every spotify.Client
and http enabledspotify.User
objects have an aiohttp.ClientSession
open underneath them.
aiohttp will emit errors/warnings for when the sessions are inappropriately destroyed, the solution is to properly close the sessions. spotify.Client
has a close
method which will close the underlying client session, spotify.User
objects have a http
attribute that have a close
method for their respective session. You must call these methods when you are discarding the objects.
The library provides an asynchronous context manager for spotify.Client
so you don't have to worry about the Client at least:
async with Client(...) as client:
await stuff
There is currently no such implementation for User objects, since they're intended to be created by other models, the client itself or via one of the User constructors such as from_code
or from_token
. The solution there is to call user.http.close()
yourself.
I'm unable to recall the extent that spotify.sync
supports the close
calls, so if there are issues there let me know :)
from spotify.py.
PS: the close
methods are coroutine functions, they must be awaited.
from spotify.py.
Related Issues (20)
- Impossible to play list of tracks HOT 2
- Player.progress_ms is only set once and not updated HOT 4
- 'Payload' referenced before assignment HOT 3
- Spotify Register Problem HOT 4
- Example with an async http server HOT 4
- OAuth needs "scopes" oauth2_url use "scope"
- edit_playlist issues when calling change_playlist_details
- Can't use parameters with user.top_artists() HOT 2
- Better http throttling post 429s HOT 2
- Right, so I've investigated the issue and have a possible fix ready. HOT 2
- Playlist attribute `tracks` is always None HOT 8
- Suggestion: allow User.recently_played() to take same optional parameters as Http.recently_played() HOT 1
- Suggestion: add support for "Add an Item to the User's Playback Queue" endpoint
- When creating a Playlist using the result of HttpClient.get_playlist() an error occurs
- Todo: Support new "Podcasts API"
- When using album.get_all_tracks(), an error is produced. `'Nonetype' has no attribute 'images'` HOT 2
- TypeError: __await__() returned a coroutine HOT 2
- Receiving an error when trying to initialize player HOT 2
- Not possible to install spotify.py and pyspotify at the same time HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spotify.py.