mendelsshop / loading_bar

Simple CLI loading bar crate

• 👋 Hi, I’m @mendelsshop

• Reach me by

• 👀 I’m interested in:

• 🌱 I’m currently learning:
  

My Github stats:

loading_bar's Issues

Auto Run possibly not working

While playing around with your library, I couldn't get auto_run to work although everything else did. I'm not sure whether this is just a problem with my computer or not. After looking more at your code for auto_run, I have a question. When you initialize a loading bar using:

let mut self_clone = LoadingBar {
    len,
    index: start,
    done: false,
    color,
    space_left: len - start,
    half: false,
    start_pos,
};

From my understanding, index keeps track of how far along the bar is, which is why you set it to start. But, on the next line you call

self_clone.advance_by_print(start);

which increments the index by start after it has already been set to start. I'm posting this issue as a question. Is this supposed to happen? Sorry to bother you.

Autorun index can be set to infinity

When using LoadingBar::auto_run you can set the length and start parameters to be the same. When the index is calculated in line 102 of src/lib.rs with let index = time_in_seconds as f32 / (len - start) as f32;, index while be set to inf because of division by 0. This will crash the program in this line:

line 112 src/lib.rs: self_clone.advance_by_print(start);

thread 'main' panicked at ' You can't advance more than the length of the bar', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/loading_bar-1.0.0/src/lib.rs:139:13

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I believe this is happening because the program tries to advance by the length of the bar which is larger than the length of the bar. And if the program kept going, the program it would then crash by trying to std::thread::sleep for inf seconds.

I guess it might be better to return a Result so you can tell the caller that they passed invalid parameters, and they can handle the errors themselves.