melvinkcx / graphql-utilities Goto Github PK

As reported graphql-python/graphene-django#810, run_only_once-decorated middleware only runs at the first request.

With graphene==3.0b1 being released, we can start looking into the integration with it.

For graphql-utilities to work with graphene>=3.0, we need to solve these issues:

• How to define cost in graphene, since schemas are defined using classes
• How to pass custom context value and ExecutionContext class for execution in graphene

Is it possible to integrate graphql-utilities with graphene-django?
The last version of graphene-django is 2.9.1 which depends on graphql-core<3.0.

Some schema may be created like normal or relay:

normal:

{
  allUsers { id username }
}

relay:

{
  allUsers { edges { node { id username } } }
}

I think, need skip edges and node in depth analysis.

The configuration can be implemented for example like this:

{
    "depth_analysis": {
        "max_depth": 2,  # Maximum depth allowed
        "skip": [EdgeClass, NodeClass],  # Do not count
     }
}

Hey I saw your issue on Graphene as I was looking around for how to have request level middleware and evidently i'm not the only person who has had this issue 😄 graphql-python/graphene#1117

Seems like your library solves that plus some other useful features but from the looks of

https://github.com/graphql-python/graphene/blob/3d0e460be166cbb7c3701a9d91030eb15c73e382/setup.py#L88

Just wondering if they were designed to work together or is this more of a replacement? Thanks and great work 👍

I think there is a bug in the decorator:

If you have multiple middlewares decorated with run_only_once only the first one will be executed because the check is written in the shared context.

Untested but something like this should work (check is bound to functionpointer):

from functools import wraps

def run_only_once(resolve_func):
    @wraps(resolve_func)
    def wrapper(instance, next, root, info, *args, **kwargs):
        if not getattr(resolve_func, "__once", False):
            setattr(resolve_func, '__once', True)
            return resolve_func(instance, next, root, info, *args, **kwargs)
        return next(root, info, *args, **kwargs)
    return wrapper

Btw. move the from functools import wraps out of the function scope, otherwise this will be a dynamic import and will reimport wraps on every call