melted / garglk Goto Github PK

On Windows XP this game works very well. But in Windows Vista the
interpreter "crash" predictable. Sometimes not enough to start and produced
the "crash" (simply, ends the execution of the interpreter). Other times,
"crashes" after a while. It is a specific error of Gargoyle on Windows Vista.

(Copy the file to the "Desktop", because for some strange reason starts
correctly when it is saved in a pendrive, for example. But if it is loaded
from the "Desktop" [or from some other directory on your hard disk, I
guess] then fails.)

(Sorry for the bad english.)

Reproduce:

Try to run any TADS3 game from IFComp '08.

Result:
gargoyle segfaults before the window is open.

What steps will reproduce the problem?
1. start a zmachine game within gargoyle
2. enter a place where there is an object
3. try to autocomplete the begining of the name of this object with tabulation

What is the expected output? What do you see instead?
With vanilla frotz in console mode, you can autocomplete the name of
objects with tabulation.

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4.zip on archlinux

Please provide any additional information below.
I don't know if this feature is related to the linux shell, but it would be
cool to have this in gargoyle also.

What steps will reproduce the problem?
1. Measure the window height in a Frotz game.
2. Resize the window height.
3. Measure the window height again.

What is the expected output? What do you see instead?
Frotz should return the updated window height, but reports the old window
height instead.

What steps will reproduce the problem?
1. Launch a TADS2 game.

What is the expected output? What do you see instead?
The window title should display the game file, but it only shows the TADS2
version.

What steps will reproduce the problem?
Playing IF with complicated maps (e.g. Zork or Anchorhead) and having to
skim through the long description of rooms to look for directions.

What is the expected output? What do you see instead?
A possibility to highlight certain words would be nice, simple
pattern/string matching. For example, one could add those lines to garglk.ini

  highlight "northeast" bold #ff0000
  highlight "northwest" bold
  highlight "southeast" bold
  highlight "southwest" bold
  highlight "north" bold
  highlight "east"  bold 
  highlight "south" bold
  highlight "west"  bold #00ff00

Those terms would then be highlighted in the text bold, and for 'east' blue
and red for 'northeast', therefore making it easier to seperate scenic
description and information about from directions to linked locations.

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4

Please provide any additional information below.

Patterns might even be regular expressions. That would be powerful and
flexible, though probably over-kill for an interactive fiction client. As I
can't think about cases where simple string comparison wouldn't suffice, I
don't think regexps would be necessary.

What steps will reproduce the problem?
1. Entering the same command several times in succession (like 'z' or 'g')
2. Scrolling up in the history for a previous command
3. Having to skim through dozens of duplicate one- or two-char commands

What is the expected output? What do you see instead?
After entering several 'dumb' commands, like trying out directions (n w s e
etc.), waiting idly (z) or repeating commands (g), it takes a while to find
a previous longer command. Shells like bash or zsh have this feature and it
is indeed useful to have an uncluttered history. 

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4

Please provide any additional information below.

The other bug occurs when you use the text style "reverse" in Glulx.
If more than one space followed in the text to be displayed, these
spaces (previous and final) are not shown in "reverse color." In
addition, the text alignment "centered" for the style
"style_Blockquote" is not working properly, and the texts are not
printing centered, but left aligned.

This prevents you can write a routine to "emulate" the style of
command Box as seen in the machine-Z.

To avoid showing these "non-reversed spaces" I discovered a trick that
is to print any character (eg one point) before and after the spaces
before and end, respectively. Example:

(# Represents the spaces, please note the dots)

.###Hello#World###.

With this trick, the spaces are displayed in the style "reverse"
correctly (but it is a "dirty trick").

Playback of Ogg Vorbis audio files: when a file Vorbis has more than 2
minutes, Gargoyle takes a little while to load. The delay is quite
noticeable. If the file is longer than 4 minutes, the delay is very
noticeable. More than 6 minutes produced an annoying delay (and the
interpreter was "stagnant" for a while).

I've attached a patch to fix build errors for the geas terp under Linux.

Compiling tads under Linux yields the following warnings:

C++ build/linux.release/tads/t23run.o 
tads/t23run.cpp:35: warning: deprecated conversion from string constant to
‘char*’
tads/t23run.cpp:35: warning: deprecated conversion from string constant to
‘char*’
tads/t23run.cpp: In function ‘void glk_main()’:
tads/t23run.cpp:182: warning: deprecated conversion from string constant to
‘char*’
tads/t23run.cpp:195: warning: deprecated conversion from string constant to
‘char*’

The installer shows "Jacl" instead of "JACL."

What steps will reproduce the problem?
1. Apply one of the stylehint_Justification hints to a style.
2. Print text in that style.
3. The text is always left-aligned.

What is the expected output? What do you see instead?

The text should follow the supplied style hint.  The initial box in Dalubi
should be centered, but is not.

What steps will reproduce the problem?
1. Type 'save' or 'restore'
2. Close window with window manager (e.g. Alt-F4, click on [x] in the upper
right corner) instead of cancel (Alt-C or click on button 'Cancel'

What is the expected output? What do you see instead?
The same behaviour 'cancel' has, i.e. closing the file selector window and
printing 'Save failed' and 'Restore failed'  respectively. 

What version of the product are you using? On what operating system?
svn r117, arch linux

Please provide any additional information below.
The problem seems to me to be this: the main window waits for the file
selector window to give a filename or a cancel signal, but closing the file
selector window just destroys it without it signalling cancel back. Now
gargoyle waits indefinitely and is therefore unusable.

What steps will reproduce the problem?
1. Start a game
2. SAVE
3. Type "test" as the file name in the dialog and save.
4. RESTORE

What is the expected output? What do you see instead?
File "test" (without an extension) is created. It should be saved as
"test.sav" because RESTORE dialog displays only "*.sav" files.

What version of the product are you using? On what operating system?
2008-10-31 on Windows XP Professional SP 2

Please provide any additional information below.

What steps will reproduce the problem?
1. Type a very long line at the prompt.

What is the expected output? What do you see instead?
The output should wrap to the next line.  Instead, text is truncated at the
edge of the screen. Editing functions should also work intelligently when
text is wrapped (arrow keys, delete & backspace.)

What steps will reproduce the problem?
1. Open any story file
2. Click the Windows Close button (top-right)
3.

What is the expected output? What do you see instead?
The application should ask me whether I really want to quit.

What version of the product are you using? On what operating system?
2008-10-31

Please provide any additional information below.

Compiling under Linux produces the following output:

Cc build/linux.release/garglk/cgstream.o
garglk/cgstream.c: In function ‘gli_put_char’:
garglk/cgstream.c:488: erreur: lvalue required as increment operand
garglk/cgstream.c:491: erreur: lvalue required as increment operand
garglk/cgstream.c: In function ‘gli_put_char_uni’:
garglk/cgstream.c:530: erreur: lvalue required as increment operand
garglk/cgstream.c:533: erreur: lvalue required as increment operand
garglk/cgstream.c: In function ‘gli_get_char’:
garglk/cgstream.c:862: erreur: lvalue required as increment operand
garglk/cgstream.c:868: erreur: lvalue required as increment operand
garglk/cgstream.c: In function ‘gli_get_char_uni’:
garglk/cgstream.c:911: erreur: lvalue required as increment operand
garglk/cgstream.c:917: erreur: lvalue required as increment operand
garglk/cgstream.c: In function ‘gli_get_line’:
garglk/cgstream.c:1168: erreur: lvalue required as left operand of
assignment
garglk/cgstream.c:1193: erreur: lvalue required as left operand of
assignment
garglk/cgstream.c: In function ‘gli_get_line_uni’:
garglk/cgstream.c:1278: erreur: lvalue required as left operand of
assignment
garglk/cgstream.c:1301: erreur: lvalue required as left operand of
assignment

gcc -c -o build/linux.release/garglk/cgstream.o `pkg-config freetype2
gtk+ --cflags` -fPIC -I/usr/include/SDL -O  -Igarglk -Igarglk
garglk/cgstream.c

...failed Cc build/linux.release/garglk/cgstream.o ...
...skipped libgarglk.so for lack of <garglk>cgstream.o... 

What steps will reproduce the problem?
Run a Z-machine game with color, such as Photopia
(http://ifarchive.heanet.ie/if-archive/games/zcode/photopia.z5).

What is the expected output? What do you see instead?
The color of the text and of the background should vary according to
commands compiled into the game file. Instead the text is always black on
white.

What version of the product are you using? On what operating system?
gargoyle-2006-09-17-linux, Kubuntu 8.04.

What steps will reproduce the problem?
Launch an Alan 3 game.

What is the expected output? What do you see instead?
The title bar should be highlighted.  It appears in plain text.

What steps will reproduce the problem?
1. Open gargoyle on just about any game
2. Type a very long line of input that is too wide to fit. Observe that the
text runs off the edge of the window and cannot be seen.
3. Press enter. Observe that the text still runs off the edge.
4. Enter a few short commands. Observe that the long line is corrupting the
display on each command.
5. Resize the window.  Observe that the long line is properly wrapped and
the graphic corruption is repaired.


What is the expected output? What do you see instead?

Expected behavior: When entering a long line, either it word wraps, or
scrolls horizontally.  When I press enter, the line is word wrapped as with
the output text.  No graphic corruption.

Observed behavior is described above in the steps to reproduce.

What version of the product are you using? On what operating system?


Please provide any additional information below.

An example of what I'm seeing is attached.  The game is "Dracula's
Underground Crypt"
(http://www.ifarchive.org/if-archive/games/competition2008/zcode/draculas/Dracul
as%20Underground%20Crypt.zblorb
), which I just happened to have sitting around.  The command is nonsense
in that game, but is valid and useful input to "Piracy 2.0"
(http://www.ifarchive.org/if-archive/games/competition2008/zcode/piracy/Piracy_2
.z5).

While I did observe this while playing Piracy 2.0, I mostly noticed it
because I had taken to writing notes to myself directly into the input,
using the script to store my notes.  My notes are frequently long, so I hit
this option.

Workaround:

Resize the window a bit.

RC2 doesn't build properly under Linux; lots of warnings and some errors. 
Attached diff improves the situation.

What steps will reproduce the problem?
1. On Ubuntu 8.04, with all updates as of October 28, 2008. You should have
libgtk2.0-dev installed, but _not_ libgtk1.2-dev.  I believe this is a
relatively "normal" install, especially given the age of GTK+ 1.2
1. Download gargoyle-2008-10-31-sources_rc1.zip
2. Unpack it
3. jam

What is the expected output? What do you see instead?
- Expected result: Successful build
- Observed result:

When I built I got a bunch of errors in the form:

Cc build/linux.release/garglk/window.o 
sh: gtk-config: not found
sh: gtk-config: not found
sh: gtk-config: not found
Cc build/linux.release/garglk/winblank.o 
sh: gtk-config: not found
sh: gtk-config: not found
sh: gtk-config: not found

When it got to sysgtk, everything fell apart, presumably because without
gtk-config it couldn't find the .h files.

Cc build/linux.release/garglk/sysgtk.o 
sh: gtk-config: not found
sh: gtk-config: not found
sh: gtk-config: not found
garglk/sysgtk.c:11:21: error: gtk/gtk.h: No such file or directory
garglk/sysgtk.c:12:28: error: gdk/gdkkeysyms.h: No such file or directory
garglk/sysgtk.c:14: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
‘__attribute__’
before ‘*’ token
garglk/sysgtk.c:15: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
‘__attribute__’
before ‘*’ token
garglk/sysgtk.c:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
‘__attribute__’
before ‘*’ token
garglk/sysgtk.c:55: error: expected ‘)’ before ‘*’ token
garglk/sysgtk.c:63: error: expected ‘)’ before ‘*’ token


What version of the product are you using? On what operating system?
gargoyle-2008-10-31-sources_rc1.zip

Please provide any additional information below.

There appear to be two ways to fix this: 

- Install libgtk1.2-dev
- "Swap" the PKGCONFIG lines for LINUX in Jamrules.  That is, comment out
line 48 and uncomment line 47.

Reproduce:
Run "A Date with Death."

Result:
A Date With Death seems to mostly work. Some strange artifacts
that I didn't notice in my playthrough of the game in Windows, but I
expect nothing to do with gargoyle and rather to do with SCARE.

What steps will reproduce the problem?
1. Run a game with gargoyle on a system with no sound
2. the CPU will load at 100 %
3. no window is appearing, no error message

What is the expected output? What do you see instead?

It's still possible to disable sound in the garglk.ini file. But gargoyle
should run the game anyway if there is no sound system available, with an
error message eventually.

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4.zip on archlinux (see
http://aur.archlinux.org/packages.php?ID=16008 )

Please provide any additional information below.

Running any Jacl game produces an immediate stack overflow.

The L9 game Scapeghost under the Windows RC2 build has issues rendering the
Amiga graphics files:

1) it's horribly slow when compared to RC1 or Tor's last build
2) the image size is not correct

Report from user:

Run an Agility game, such as Shades of Gray.  Attempt to exit the program.
 It does not close.

- Turn transcript on in a game.
- Enter commands with more than a single letter.
- Turn off transcript.
- Review output.  Letters are displayed in a weird way.  The echo_stream
functions must be broken somehow.

- Build wxWidgets binary .dll for Windows.

- Build wxC.dll from the wxHaskell project:
http://darcs.haskell.org/wxhaskell/wxc/

- Include wxC.dll and wxC.h in the support files.

Error message:

Link build/linux.release/agility/agility 
/usr/bin/ld: build/linux.release/agility/agtread.o(.text+0xf28):
unresolvable R_386_32 relocation against symbol `start_time'
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status

What steps will reproduce the problem?
It is not really a problem, using Pos1, End, Backspace and cursor keys work
fine.

What is the expected output? What do you see instead?
That said, it would be nice to have GNU ReadLine like shortcuts, i.e. 
  * ctrl-a : start of line
  * ctrl-e : end of line
  * meta-f : forward one word
  * meta-b : backard one word
  * ctrl-right : forward one word
  * ctrl-left  : backward one word
  * ctrl-k : delete to end of line

plus maybe clipboard/selection/primary selection support as proposed by
Issues [[http://code.google.com/p/garglk/issues/detail?id=7|7]] and
[[http://code.google.com/p/garglk/issues/detail?id=7|8]], for the command line.

Also, 'Delete', the "delete character under cursor" delete key, would be
nice to have.


What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4, linux

Please provide any additional information below.
These are not essential, though it would make long "guess the verb"
sessions more comfortable and fit in with my habits from other shell-like
environments.

What steps will reproduce the problem?
1. Start up gargoyle on any game under Linux.  Do whatever you need to do
to get to a prompt.
2. Select some text in a terminal program; I happen to use gnome-terminal,
but this should work in xterm, rxvt, and KDE's terminal.  You should be
able to use just about any modern text editor as well wherever I say
"terminal."
3. Middle click in that same terminal.  Observe that the selected text is
pasted.  If you lack a middle mouse button, clicking both buttons
simultaneously is equivalent on many Linux distributions.
4. Middle click into gargoyle window.  Observe that the selected text is
not pasted.
5. Explicitly copy text from the terminal window. (Ctrl+Shift+C in
gnome-terminal; other terminals should have similar commands.)
6. Explicitly paste text into the terminal window.  Observe that the copied
text is pasted.
7. Try Ctrl+V in the gargoyle window.  Observed that the copied text is not
pasted.

What is the expected output? What do you see instead?
Expected behavior: Middle clicking will paste the contents of the selection
buffer.  Ctrl+V will paste the contents of the copy buffer.

(I'm not an X programmer, so I may be mangling the terminology.  By
"selection buffer" I mean "the buffer you automatically fill by selecting
text, and usually can paste by middle-clicking."  By "copy buffer" I mean
"the buffer you explicitly copy and paste things from, typically with
Ctrl+C and Ctrl+V in modern Gnome/KDE applications.)


What version of the product are you using? On what operating system?
gargoyle-2008-10-31-sources_rc1.zip
Ubuntu 8.04


Please provide any additional information below.

This is occasionally a nuisance when you have a complex command you need to
retype into a game, or when copying chunks of a walkthrough.

I've filed this separately from
http://code.google.com/p/garglk/issues/detail?id=7 because while they are
related, they can be implemented separately and have different
implementation details.

Please, make that in Windows, the Gargoyle launcher
uses first the Glulxe interpreter, and not Git (as is right now),
because this last one doesn't work well in a lot of configurations
(actually it has a lot of problems with a Spanish system called
Superglus and with some configurations of the new version of Damusix
I6 [v3/0801104] to be used in the version of Damusix for Inform 7). 

What steps will reproduce the problem?
1. Launch any Quest game from IF Comp / IFDB.
2. Convert the game to .asl using the uncas.pl script.
3. Launch the converted game.

What is the expected output? What do you see instead?
The game does not play properly until it is decrypted.

What steps will reproduce the problem?
1. Use ArchLinux on eeePC 1000h
2. build garglk from source
3. start it with any game (tried at least one game for each terp backend)

What is the expected output? What do you see instead?
It should start. But doesn't.

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4 and subversion repo

Please provide any additional information below.
I don't understand what's causing this. I tried the statically linked
gargoyle binaries from tor's site and they work fine. I also compiled a
debug build (as per the INSTALL file), but no output either, just 100% CPU
and nothing.

What steps will reproduce the problem?
Misspelling complicated game-specific or generic terms all the time, like
'refrigerator' or 'through' (yeah, I know, those should be simple to type,
but aren't for me...)

What is the expected output? What do you see instead?
It would be cool to have an alias expansion, so one can (dynamically while
playing or statically via garglk.ini) assign longer words to short
abbreviations, like the 'alias' command in bash/zsh/tcsh or in MUD clients.
Using them one could define in a (game-specific) ini file

  alias lkt  "look through "
  alias lin  "look in "
  alias swon "switch on "
  alias swof "switch off "
  alias src  "search "

Or even global aliases as in zsh

  alias -g thru "through"
  alias -g fridge "refrigerator"

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4

Please provide any additional information below.

This is low priority, probably not that many people would use it, but I'd
find it great. 

What steps will reproduce the problem?
Run a zcode game that uses Unicode characters.  See attached: Russian
translation of "Metamorphoses."

What is the expected output? What do you see instead?
Available glyphs should be displayed.  ? is shown for all Unicode characters.

What steps will reproduce the problem?
1. Run gargoyle with just about any game.
2. Play the game for long enough to have a few screens of output
3. Click and drag on the elevator in the scrollbar

What is the expected output? What do you see instead?

Expected behavior: Text and elevator scrolls up and down along with the
mouse pointer.  This is typical behavior for scrollbars for most modern
desktops.

Observed behavior: The elevator jumps one screen of text, upwards if you
happen to click in the top half of the scroll bar, downwards for the bottom
half.


What version of the product are you using? On what operating system?
gargoyle-2008-10-31-sources_rc1.zip
Ubuntu 8.04

Reproduce:

Run berrosts.gam.

Result:
prints the tadsr header and then the error: [TADS-609: unknown resource
type in .gam file]

Currently, jacl is associated with .jacl files in both launcher.c and
launcher.sh.  It should also be associated with .j2 files.

Report from Alan De Smet:
(http://emshort.wordpress.com/2008/10/29/a-halloween-experiment/)

"To build Gargoyle on my system, Ubuntu 8.03, I had to uncomment out the
PKGCONFIG line in the Jamrules file, then comment out the next one. It also
didn’t compile Agility for AGT, but I’m not going to lose any sleep over 
that."

terps/agility/os_glk.c: In function ‘gagt_cp_to_iso’:
terps/agility/os_glk.c:814: warning: comparison is always true due to
limited range of data type
terps/agility/os_glk.c: In function ‘gagt_iso_to_cp’:
terps/agility/os_glk.c:883: warning: comparison is always true due to
limited range of data type

What steps will reproduce the problem?
1. install OSS instead of Alsa.
2. the sound is working fine for other software (vlc, flash, sdl games such
as rocks'n'diamonds)
3. No sound, gargoyle hangs if sound is not turned off in garglk.ini (as
described in issue 41
http://code.google.com/p/garglk/issues/detail?id=41#c0 )

What is the expected output? What do you see instead?
Other Unix systems such as FreeBSD don't use Alsa, and OSS is more platform
independant. Gargoyle doesn't seem to work with OSS.

What version of the product are you using? On what operating system?
gargoyle-2008-11-22-sources_rc4.zip on archlinux (from 
http://aur.archlinux.org/packages.php?ID=16008 )

Please provide any additional information below.

May not support graphics, if the graphics functions in glk.c work
differently than in Tor's glkgfx.c.

Lancelot may be a productive test game - if I can track down a copy.

Rev #86 introduces a dependency on libsdl-sound-1.2-dev, but when this is
linked in, the terps use 100% CPU time on startup.

TADS3 places the story name (not the file name) in the Window title.

Likewise with SCARE.

What steps will reproduce the problem?
1. Build and install gargoyle
2. Load a game, just about an should work
3. Try to select some text with the mouse.

What is the expected output? What do you see instead?
Expected behavior: Text is selected (and made available as the selection
buffer to X).  I should also be able to use Ctrl+C to copy into the copy
buffer.

Observed behavior: Cannot select text at all.

(I'm not an X programmer, so I may be mangling the terminology.  By
"selection buffer" I mean "the buffer you automatically fill by selecting
text, and usually can paste by middle-clicking."  By "copy buffer" I mean
"the buffer you explicitly copy and paste things from, typically with
Ctrl+C and Ctrl+V in modern Gnome/KDE applications.

What version of the product are you using? On what operating system?
gargoyle-2008-10-31-sources_rc1.zip
Ubuntu 8.04

Please provide any additional information below.

This is a problem when wants to copy a short bit of text for a bug report
to the game's developer.  The workaround is to turn on the transcript
(usually "script" in game), but it's easy to forget until it's too late.

This behavior is very old to Gargoyle, and is probably the result of
Gargoyle reinventing the display system from nearly scratch.  As such, this
is arguably a feature request and not a bug; please let me know if you're
not interested in having feature requests logged here.

Reproduce:

Try to run "forbidden.a3c"

Result:
prints the introduction but then blows up with: SYSTEM ERROR: could not
read all ACD code. (or is that introduction just some generic part of the
error message instead of part of the game?)

garglk/sysgtk.c: In function ‘winopenfile’:
garglk/sysgtk.c:79: warning: passing argument 3 of
‘gtk_signal_connect_full’ from incompatible pointer type
garglk/sysgtk.c:81: warning: passing argument 3 of
‘gtk_signal_connect_full’ from incompatible pointer type

Warnings appear when compiling with Gtk 2.0.  The fix may involve breaking
backwards compatibility with Gtk 1.0.