melanx / aiotbotania

This mod adds AIOTs to Botania.

AIOT Botania

This mod adds a few new items! That is Hoes and AIOTs (All In One Tool), each as a Manasteel and as an Elementium version. Since version 0.6 also Livingwood and Livingrock tools are included.

More information about the single items can be found on the wiki page.

Here you can see all the items which are included at the moment:

Here you see the glimmering Super Farmland block:

Feel free to use this mod in any of your modpacks and please tell me what you think about this mod! <3

aiotbotania's Issues

Sword enchantments on AIOTs

Enchantments for swords (like sharpness) don't fit to AIOTs

Suggestion to improve the display of AIOT modes

• Change the color of switching AIOT modes to clearer. The colors of the modes should be different from each other.
  §6 "gold": §e "yellow"

§6 "gold": §a "green"
  
• Add the name of the mode to the AIOT description.
  
  It can be used with different colors (which I wrote about above) or as in Botania:
  

java.lang.NoSuchFieldError: SEEDS

Versions
aiotbotania-1.16.2-1.3.1.jar
Minecraft: 1.16.1
Forge: net.minecraftforge:32.0.108
Botania: Botania-1.16.1-403.1.jar
AIOT Botania: aiotbotania-1.16.2-1.3.1.jar
Modpack: valhelsia-3

Describe the bug
it crashed

How to reproduce
sorry not a clue

Expected behavior
no crash

Screenshots
here's a pastebin https://pastebin.com/Wm4FABut

Renam CommonProxy to ServerProxy

As the class called CommonProxy is only used on the server it either be renamed to ServerProxy or ClientProxy should extends it. A CommonProxy as the name says is usually instantiated on both sides not just on the server. This is very minor but it might confuse new developers.

Mode for stripping logs

Problem: At the moment I'm unable to strip logs with the AIOTs. As the recipe includes an axe it feels like it should be an option to strip logs like you would with a normal axe.

Suggestion: Add a feature to be able to strip logs, like a mode or just by default.

As a builder, I have to carry an axe with me to be able to decorate with stripped logs. I would love to be able to use only the AIOT.

[1.16.4] Shears don't function as shears

Versions

Minecraft: 1.16.4
Forge: 1.16.4-35.1.4
Botania: 1.16.3-409
AIOT Botania: 1.16.3-1.4.3
Modpack:
Enigmatica 6

Describe the bug
When Shears are used on Grass, the Grass is not dropped.

How to reproduce

1. Shear Grass

Expected behavior
For Grass to be dropped when harvested with Shears.

The shears are also missing the forge:shears tag, which could be the reason for the bug tbh.

Refactor and clean up

Is your feature request related to a problem? Please describe.
There's lots of duplicate code (e.g. ToolUtil), a lot of unnecessary code in general, whilst better solutions are available. That would also solve problems like mod support, wrong block breaking speeds, not supported functions etc.

Describe the solution you'd like
Refactor, refactor, refactor.

• There should be a file for static references to Botania's tools, so you redirect actions to those, instead of duplicating code from those classes
• ItemAIOTBase should then store these references in a list and forward the applicable action to one item in that list according to priority/condition
• Generate livingrock and livingwood items by using a base class and passing values (right now: a lot of files with only a few statements -> should deduplicate/decouple)
• Remove LibMisc. It's confusing 5621ac8
• Make use of proxies (would solve the client <-> server issues) and move specific functions to them 2e45da5
• Make use of Java 8 Streams API, thus preventing endless if statements and overhead in general
• Comment a lot more
• Probably other stuff as well

Describe alternatives you've considered
- / -

Super Farmland not possible to make

Versions
Minecraft: 1.14.4
Forge: 28.1.109
Botania: r1.11-373
AIOT Botania: 1.0.1
Modpack: ATM4 0.3.0

How to reproduce

1. Use Elementium Hoe/AIOT to create Super Farmland
2. There is normal farmland

Expected behavior
Super Farmland is made

Terrasteel AIOT doesn't work with mana generating items

The terrasteel AIOT doesn't work when mining stone or wood whenever I have any sort of mana generating item equipped (ring of aura, set of terrasteel armor). It will mine blocks that instantly break but nothing else.

AIOT mode change doesn't work on server

Has probably something to do with nbt data...

Durability issue

Manasteel Hoe/AIOT, Elementium AIOT durability: 300
Elementium Hoe durability: 720

Remove hoes in favor of those recently added in base Botania

Botania 1.16.4-414 added manasteel and elementium hoes. These have the same recipes as those added by AIOT Botania.

The AIOT recipe only accepts hoes from its own mod, which are not craftable due to a recipe conflict with the ones added by base Botania.

AIOT mining level is wrong

both - elementium and manasteel

Primary Effects of elementium tools aren't implemented in AIOT

Pickaxe deletes broken stone, cobblestone, netherrack and dirt stuff. AIOT drops these items.

Shift-Rightclicking on blocks to use AIOT's secundary function plays wrong animation

I'll probably fix it by increasing the number of AIOT modes from 2 to 4, effectively removing all secundary functions which require pressing the shift key.

Use offhand item if no torches in inventory

Is your feature request related to a problem? Please describe.
I would prefer that if I do not have torches in my offhand that my manasteel aiot uses the item in my offhand instead of just swinging and nothing happening

Describe the solution you'd like
If there are no torches in the player inventory, try to use the offhand item instead

Describe alternatives you've considered
I currently have to switch to another hotbar slot just to use my offhand item. This isn't game breaking, just inconvenient

Improve Superfarmland

It would be nice if the superfarmland would have light pink particles (like a manapool but pink). So it looks like elven keep the farmland wet because it’s made with Elementium AIOT/Hoe.

Add shears

Is your feature request related to a problem? Please describe.
Shears are still missing

Describe the solution you'd like
add Livingwood Shears
add Livingrock Shears

Describe alternatives you've considered
you could think about features for the different types of shears

Cannot activate anything with AIOTs

If I have an AIOT in my main hand I cannot open chests or something similar to this.

Ditch superfarmland

Is your feature request related to a problem? Please describe.
Superfarmland is a hacky and very not elegant way of achieving a simple task. It's just prone to bugs (missing mod support, not fireing the UseHoeEvent it does apparently, can't plant anything onto it) and requires a great amount of manual work

Describe the solution you'd like
Not sure if this will work, but I envision intercepting the UseHoeEvent and spawning a TileEntity at the block coordinates, which then in turn prevents destruction of farmland etc.

Describe alternatives you've considered
Using ASM to directly hook into the farmland block. This probably wouldn't cover any soil/farmland from mods and possibly break any other overriding mods, but might be a better solution as a lot of TileEntities tend to lag the game (which would then happen if you tilt lots of soil). But this still needs further testing

(Redstone) Torches can be placed on Superfarmland

torches on normal farmland isn't possible

Block breaking speed

Versions
Minecraft: 1.14.4
Forge: 28.0.49
Botania: not released
AIOT Botania: not released
Modpack: ---

Describe the bug
Many blocks can't be broken like the normal tools with AIOT.

How to reproduce

1. Get an AIOT
2. Try to break Grass
3. See the slow progress

Expected behavior
Progress is as fast as normal shovel or pickaxe or axe.

AIOTs don't fit into mana enchanter

If you want to use the Enchanter by Botania you cannot enchant them/put them into the Enchanter

Improve durability

The AIOts of Actually Additions stack the durability instead having the same as the tools they are made of.

• JonasCiss

Neither Terrasteel nor Alfsteel AIOT break Astral Sorcery marble in area mining mode.

Versions
Minecraft: 1.16.5
Forge: Forge - 36.1.31
Botania: Botania-1.16.5-419.jar
AIOT Botania: aiotbotania-1.16.5-1.8.0.jar
Modpack: Enigmatica 6

Describe the bug
Neither Terrasteel nor Alfsteel AIOT break Astral Sorcery marble in area mining mode.

How to reproduce

1. Mine with AIOT in area mode.
2. Astral Marble remains.

Expected behavior
Astral marble mined out.

Botania fixed this with:
Check harvest speed in addition to block material for terra pick

Breaking blocks crashes the server

Versions

Minecraft v1.16.4
Forge v35.1.13
Botania v410
AIOT Botania v1.4.3

Describe the bug

• Breaking a block with the SS Terrasteel AIOT crashes the game. I was in creative on a server at the time.
• Crash Report

How to reproduce

1. Craft AIOT
2. Break a block

Expected behavior

• No crashes.

Screenshots

images in readme/curseforge

Images are nice to have. Would be nicer for users if they're searching for new mods.

Terra Spade/Hoe Attack Speed

The attack speed on the Terrasteel Spade and Terrasteel Hoe are 19 instead of 1.9. Very OP

Update Curseforge icon to match the new textures

The Curseforge project's icon is still using the textures from before the recent texture rework.

Wrong informations in lexica botania

Versions

Minecraft: 1.14.4
Modpack: ATM4 (latest version)

Describe the bug
Wrong Informations:

• Every shear
• There are three new manasteel items instead of two (there are shears)

How to reproduce

1. Just look into the lexica botania

Expected behavior

Show the right information. lol

Farming station (EnderIO) support

The AIOTs don't work in the farming station by EnderIO. Fix it. Now. NOW! Kappa

Lexica Botania

add Lexica Botania pages four the for (lol) tools

Hoes doing wrong

A normal hoe makes dirt from coarse dirt.
You're hoe makes farmland. That's a bug, not a feature.

Languages

Other language files than en_us.json should be reformatted, too.

Crash when breaking blocks

I've been having the my game randomly crash when breaking blocks with the Elementium AIOT. I have it enchanted with Efficiency V and Fortune III and have mana in my inventory to repair it. It seems to happen more often when breaking gravel.

crash-2019-02-13_20.16.54-client.txt

Superfarmland and Melon/Pumpkins

Versions

Minecraft: 1.16.5
Forge: 36.0.45
Botania: Botania-1.16.5-415 with curios-forge-1.16.5-4.0.5.1 and Patchouli-1.16.4-50
AIOT Botania: aiotbotania-1.16.4-1.7.5
Modpack: Garden of Glass questbook edition However, I also stripped it down to just the four mods listed above and the problem persisted. I also updated the mods to the most current versions (as shown above) and the problem persists.

Describe the bug

I'll just use the term melon in this issue, however tests holds true for both melon, pumpkins, or a mix of the two.

When two melons are planted side by side on superfarmland, there is a chance they pop their seeds out of the ground (breaking the stem).

• Problem persists regardless of external hydration or light level.
• The problem doesn't occur 100 of the time
• I've been unable to reproduce the error with only one stem, but I can't guarantee it. But I've been messing around for about 2 hours altering conditions and it hasn't happened yet.
• Problem doesn't occur on regular farmland

How to reproduce

1. Create at least two superfarmland side by side
2. Plant melon seeds
3. Eventually the stems will pop

Expected behavior

Screenshots

Video of a test @ tick speed of 600 (happens at default of 3).
Video of a test @ tick speed of 200. The last 15 seconds or so show that it doesn't matter if the melons both spawn on the same side nor do they need to spawn at nearly the same time.

Shears do not work on beehives

Versions

Minecraft: 1.16.4
Forge: 35.1.13
Modpack: Valhelsia 3

Describe the bug

All the shears do not work on beehives.

AIOT Bug

Bug with durability bar when break block and Mana Tablet in inventory

[1.16.5] Using /reload breaks Terrasteel/Alfsteel AIOT recipes

Versions

Minecraft: 1.16.5
Forge: 1.16.5-36.0.10
Botania: 1.16.4-411
AIOT Botania: 1.16.4-1.7.0
Modpack: Enigmatica 6 0.3.11-indev

Describe the bug
Terrasteel/Alfsteel AIOT recipes disappear from JEI and no longer function after using the /reload command and waiting for that to finish.

How to reproduce

1. Use the /reload command
2. Check JEI for Terrasteel/Alfsteel AIOT recipe
3. Try to craft a Terrasteel AIOT

Expected behavior
For the recipes to stay

Screenshots

Durability of hoes will not be drained

when break block with a hoe durability will not go down
you know what I mean :D

Error in Logs

Versions

Minecraft: 1.16.1
Forge: 32.0.108
Botania: 1.16.1-1.3.2
AIOT Botania: 1.16.2-1.3.1
Modpack: Valhelsia 3 3.0.20

Describe the bug
[07:30:08] [AIOT Botania Contributor Thread/INFO] [de.me.ai.AIOTBotania/]: Oops, a wrong number at noeppi_noeppi

How to reproduce
Discovered in logs.

Expected behavior

Screenshots

Terrasteel aiot

Versions
Minecraft: 1.16.5
Forge: 36.0.46
Botania: 1.16.4-413
AIOT Botania: 1.16.4-1.7.2
Modpack: valhElsia 3 3.2.0b

Describe the bug
I'm able to use the terrasteel aiot to take down a full tree in one block like the terrasteel axe.

How to reproduce

1. Grab terra axe use on tree. Mines whole tree from one block.
2. Grab terrasteel aiot. mine tree only breaks one block

Expected behavior
Terrasteel aiot would mine whole tree from one block like the terrasteel axe.

License change

I want to change to license from MIT License to Apache 2.0 License. More information can be found here: https://www.apache.org/licenses/LICENSE-2.0.txt

Before I change it, I need permissions from all contributors of this project. All the users below, do you agree the change to Apache 2.0?

• @derkalaender
• @noeppi-noeppi
• @Ridanisaurus
• @yappy2000d
• @flier268
• @DYColdWind
• @Imbarainbow
• @derNiklaas
• Vik (on Discord)

Terrasteel AIOT not working with Terrasteel armour

Versions

Minecraft: Forge: 1.16.3
Botania: 1.16.3-408
AIOT Botania: 1.16.2-1.3.2
Modpack:

All the mods 6 1.1.5 https://www.curseforge.com/minecraft/modpacks/all-the-mods-6
Describe the bug

Terrasteel AIOT does not mine blocks that cannot be insta mined. when full terrasteel armour is worn. Looks like it does a single hit and then resets.
How to reproduce

1. Install ATM6 instance
2. give yourself terrasteel armour and terrasteel AIOT
3. Try to mine

Expected behavior

For the terrasteel AIOT to mine blocks

Screenshots

[1.16.5] Veinmining with Livingrock Shears stops blocks from dropping blocks

Versions

Minecraft: 1.16.5
Forge: 1.16.5-36.1.13
Botania: Botania-1.16.5-415
AIOT Botania: aiotbotania-1.16.4-1.7.5
Modpack: Enigmatica 6 v0.4.10-indev

Describe the bug
Using Ultimine (veinmining) with Livingrock Shears causes all blocks to no longer drop anything.

How to reproduce

1. Make an instance with AIOT Botania and FTB Ultimine
2. With a papir of Livingrock Shears in-hand, hold the Ultimine keybinding
3. Destroy grass
4. See issue

Expected behavior
For grass to drop

Relevant part in log is line 14089
latest.log

Manasteel AIOT Mining-Level

Versions

Minecraft: 1.14.4
Forge: 28.1.109
Botania: latest :P
AIOT Botania: latest :P
Modpack: ATM4

Describe the bug

Manasteel AIOT doesn't drop livingrock

How to reproduce

1. break livingrock with Manasteel AIOT
2. ...
3. Profit

Terrasteel/Alfsteel AIOT have no Crafting Recepie

We are playing with version 1.5.0 and noticed that the Terrasteel/Alfsteel AIOT have no recipe.
I dont think this is intended.

Super Farmland unusable

Versions

Minecraft: 1.14.4
Forge: 28.0.49
Botania: not released
AIOT Botania: not released
Modpack: ---

Describe the bug

If you try to plant a seed on Super Farmland it isn't possible.

How to reproduce

1. Create Super Farmland by Elementium Hoe/AIOT
2. Try to plant a seed

Expected behavior

The Super Farmland behaves like the normal Farmland.

IF machines not working with Super Farmland

Versions
Minecraft: 1.14.4
Forge: 28.1.109
Botania: r1.11-373
AIOT Botania: 1.0.2
IF: 2.1.2

Describe the bug
Machines from IF can't interact with Super Farmland.

How to reproduce

1. Use a plant sower by IF.
2. Create Super Farmland to let the sower work.
3. Nothing happens.

Expected behavior
Sower will plant like on normal farmland.

Server crash

Versions

Minecraft: 1.16.5
Forge: forge-1.16.5-36.0.1
Botania: Botania-1.16.4-411
AIOT Botania: aiotbotania-1.16.4-1.6.0
Modpack:

Describe the bug

crash report
How to reproduce

1. Active TerraSteelAIOT
2. Break tree

Expected behavior

Screenshots