mehdi-rh / to-do-list

This web application was build the microverse program, it's about implementing functionalities using JavaScript

To-Do list

One paragraph statement about the project.

Additional description about the project and its features.

Built With

• Major languages : HTML, CSS, Javascript.
• Other modules: npm, webpack

Live Demo

Live Demo Link

Usage

To build the project run :

$ npm install
$ npm run build

Run tests

Deployment

In development environment use the following command:

$ npm run dev

Authors

👤 Mehdi Rahal

• GitHub: @githubhandle
• Twitter: @twitterhandle
• LinkedIn: LinkedIn

🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the issues page.

Show your support

Give a ⭐️ if you like this project!

Acknowledgments

• Hat tip to anyone whose code was used
• Inspiration
• etc

📝 License

This project is MIT licensed.

to-do-list's Issues

week2 - Morning session

Hello,
✔️ your logic looks wonderful, and I love the Read me file too
✔️ your folder organization is great too
✔️ you implemented all features as instruction .
some suggestion:
your index.js file can be smaller and divided to two or three js file.

Morning session review

You did a great job 👏🏼 👏🏼
To highlight 💪🏻
No linter errors. ✔️
Good commit history ✔️
👍 Good job!
Optional changes:
It will be better if you divide your js function into some files, It will be more readable and reuseable in future projects.

DRY issue

In the src/classes.js file a repeated set item to local storage which could be refactored into a simple function

• To-Do-List/src/classes.js

  Line 19 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(ToDo.task));

• To-Do-List/src/classes.js

  Line 28 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(taskNewIndex));

• To-Do-List/src/classes.js

  Line 35 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(update));

• To-Do-List/src/classes.js

  Line 42 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(selection));

• To-Do-List/src/classes.js

  Line 52 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(ToDo.task));

• To-Do-List/src/classes.js

  Line 52 in d76a9b8

  localStorage.setItem('taskInfo', JSON.stringify(ToDo.task));

Update the README file

You have done a great job, by implementing the required tasks such as 👍

• ✔️ removing button
• ✔️ adding button
• ✔️ storing data in local storage
• ✔️ Generate dynamically with JavaScript

But we would suggest updating your README file because both your live demo and MIT links are broken, please create an MIT file(MIT.md) within your project and use the correct link to display your live demo by adding(dist/) at the end of your demo link.

Kiss issue

There are many old for loop that can be replaced by a ForEach loop

Yagni issue

The piece of code below can be refactored into only one line

To-Do-List/src/classes.js

Lines 47 to 51 in d76a9b8

	if (completed) {
	ToDo.task[index].completed = true;
	} else {
	ToDo.task[index].completed = false;
	}

Refactoring:
ToDo.task[index] = !!completed