Comments (5)
Sure, done. Note though that the whoisit
PyPI package just has a requirement of requests
without a pinned version. Bumping the required version in the Pipfile
(to resolve this issue) doesn't change the package in any way and most people who install the package from PyPI are unaffected by this. Thanks for the issue!
from whoisit.
Thanks for resolving the issue so quickly!
from whoisit.
As an update, I think there might be another issue with urllib3 2.x with DEFAULT_CIPHERS being removed. Should the ssl module and ssl.create_default_context() be used to set the value?
For example, something like the following in utils.py
. I haven't tested it.
import ssl
ssl_context = ssl.create_default_context()
< Optionally set ciphers >
ssl_context.set_ciphers('...')
<>
request.packages.urllib3.util.ssl_.DEFAULT_CIPHERS = ssl_context.get_ciphers()
Let me know what you think and if I should create a separate issue.
Thanks!
Wes
from whoisit.
Ah, yes that will require an additional patch. Looks like it will need to be moved to a requests adapter. Feel free to create an new issue.
from whoisit.
Will do. Thanks!
from whoisit.
Related Issues (19)
- Some rdap servers seem to exhibit weak security, which throws errors HOT 2
- Parsing of address, telephone and individual name ("n") field HOT 8
- IP address lookup returns only the first CIDR on the list HOT 3
- No valid RDAP service URLs could be parsed HOT 2
- whoisit does not find the RDAP endpoint for UK domains HOT 4
- Mutable defaults parameters en request wrapper HOT 1
- Failure when sld require different url than tld HOT 7
- Implement an async mode HOT 3
- urllib3 2.x complains about DEFAULT_CIPHERS HOT 5
- Benchmarking whoisit against registrant name HOT 5
- Can the route information be returned when using whois + IP? HOT 4
- Follow related links HOT 3
- Feature Request: Add support for unicodeName HOT 4
- Exception 'AttributeError' raise for some domains HOT 3
- RDAP server connection error handling (for discussion) HOT 6
- Feature request: Releases HOT 3
- domain entity: handle requirement HOT 5
- setup.py itself depends on python-dateutil HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whoisit.