Coder Social home page Coder Social logo

Comments (7)

meeb avatar meeb commented on August 24, 2024

whoisit by default directly refers queries to RDAP endpoints as listed in the IANA bootstrap data. If these ccTLDs aren't resolving properly than that's the exact use case the overrides facility exists. Feel free to submit a PR with these overrides added and I'll give it a test. The only issue here is if a ccTLD has an RDAP endpoint that's not referred to by the IANA initial hint data the response format may be non-standard so some of the parsed data might be missing some values (so you may need to use raw=True for example).

Happy to add any relatively sensible overrides into the next release though if you want to suggest some.

from whoisit.

tmuncks avatar tmuncks commented on August 24, 2024

The problem is more that the code does not support looking up the RDAP endpoint for an sld, only for an tld.

So whoisit.domain('example.net.gl') will always only look for gl in the bootstrap data, not net.gl which is what is required for centralnic.

It's described at https://centralnicregistry.com/support/information/rdap:

Unfortunately, since the IANA can only accept registrations for top-level domains, CentralNic's SLD portfolio cannot be added to the registry. However, the RDAP service is available for these domains, at https://rdap.centralnic.com/{sld}.

I will happily submit a PR to support this type of overrides, if it seems acceptable to you.

from whoisit.

meeb avatar meeb commented on August 24, 2024

Ah right sorry I didn't follow that was the issue originally. It should be relatively easy to add SLD support for TLDs that don't explicitly list the SLDs. I'll pop it into the next release. Thanks for the detailed issue.

from whoisit.

tmuncks avatar tmuncks commented on August 24, 2024

Sounds good. Thank you.

FWIW, I did raise the issue with centralnic as there are many other advantages to using the same RDAP endpoint for all domains under a tld (including the slds). I do feel that adding support here will be both easier and certainly add some flexibility to things at the same time.

from whoisit.

meeb avatar meeb commented on August 24, 2024

v2.6.4 which is just released now should support second level domain overrides. I've added your gl overrides to overrides.py as well.

from whoisit.

tmuncks avatar tmuncks commented on August 24, 2024

Works absolutely perfectly! Thank you.

For the sake of completeness, this is the full list of GL SLDs. The change to the actual lookup code was all I was hoping for, so I'm more than happy to simply provide my own overrides, but I want you to at least be aware of these.

Thanks again.

'gl': ['https://rdap.centralnic.com/gl/'],
'co.gl': ['https://rdap.centralnic.com/co.gl/'],
'com.gl': ['https://rdap.centralnic.com/com.gl/'],
'edu.gl': ['https://rdap.centralnic.com/edu.gl/'],
'gov.gl': ['https://rdap.centralnic.com/gov.gl/'],
'net.gl': ['https://rdap.centralnic.com/net.gl/'],
'org.gl': ['https://rdap.centralnic.com/org.gl/']

from whoisit.

meeb avatar meeb commented on August 24, 2024

Sure, updated the gl override list but I won't do a full release now just for those so they'll be in the next release whenever that is.

from whoisit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.