See https://make.wordpress.org/core/2021/06/25/introducing-theme-json-in-wordpress-5-8/

Hello!
Just here to say a big thanks. I was using Foundation Press for a long time, even contribute for some translation and bug correction in the past. Was sad to see the project is discontinued but here you are with an updated version.
I was about to update it but as you already made it!
Will keep an eye on this one and maybe add some update and helpers I made along the way.
V.

Fresh server instance, newly installed Wordpress. Build and installed the theme successfully (not using Local by Flywheel as the host as in previous attempts to install and use/build this theme, rather using LAMP).

I'm getting a warning that I need ACF Pro ... is this expected?

How can this bug be reproduced?

1. Install per instructions
2. Move folder to appropriate path on server
3. Activate theme

What did you expect to happen?
Not see an error in the admin panel

What happened instead?
Error: "You need to have Advanced Custom Fields Pro installed to make the theme work properly!"

Please List the Following:

• OS & version: Fedora Core 28 5.0.16-100.fc28.x86_64
• Node version: v11.13.0
• FoundationPress version: 3.4.3
• Foundation version : [email protected]

Include Test Case (if applicable):

I don't see how I can do this.

This is a recommendation from Google Page Speed Insights

Polyfills and transforms enable legacy browsers to use new JavaScript features. However, many aren't necessary for modern browsers. For your bundled JavaScript, adopt a modern script deployment strategy using module/nomodule feature detection to reduce the amount of code shipped to modern browsers, while retaining support for legacy browsers. Learn More

How can this bug be reproduced?

1. Install FoundationPress per instructions
2. Zip theme folder & upload via wordpress, & activate theme
3. Attempt to add user

What did you expect to happen?
Add user should work

What happened instead?
The password input box is not displaying and therefore cannot be used. This happens on all of my deployed themes (I tested 5, and then stopped testing). Since I've never added a user after a installing a theme, this has never cropped up before. I affirm that changing themes to any other theme the functionality of adding a user works correctly on the 5 different installations

Please List the Following:

• OS & version: Fedora Core 28 64
• Node version (node -v) [Node v4+ is required] : v10.19.0 & v11.13.0
• FoundationPress version (see line 3 in package.json): "version": "3.4.1", (actually this is in line 4)
• Foundation version (found in node_modules/foundation-sites/package.json) : [email protected]

Include Test Case (if applicable):
I don't see how I can do that.

Thank you.

For an example implementation see this workflow:
https://github.com/flyntwp/flynt/blob/master/.github/workflows/release.yml

See https://github.com/foundation/foundation-sites/releases/tag/6.7.2

Deprecated: block_categories is deprecated since version 5.8.0! Use block_categories_all instead. in .../wp-includes/functions.php on line 5458 Deprecated: block_categories is deprecated since version 5.8.0! Use block_categories_all instead. in .../wp-includes/functions.php on line 5458

File which need to be changed:
https://github.com/MEDIADUDES/FoundationPress/blob/master/inc/gutenberg.php#L60

I ried appending to a closed issue, which apparently won't be re-opened.

How can this bug be reproduced?

cd my-wordpress-folder/wp-content/themes/
git clone https://github.com/MEDIADUDES/FoundationPress.git
cd FoundationPress
npm install
composer install
npm run build
live preview the newly built theme

What did you expect to happen?
Expected to see live preview

What happened instead?
Fatal Error

Please List the Following:

OS & version: Fedora Core 28 64
Node version (node -v) [Node v4+ is required] : v10.19.0 & v11.13.0
FoundationPress version (see line 3 in package.json): "version": "3.4.1", (actually this is in line 4)
Foundation version (found in node_modules/foundation-sites/package.json) : [email protected]

Include Test Case (if applicable):
Not possible

/////////////////////////////////////////////////////
( ! ) Fatal error: Uncaught Error: Call to undefined function FoundationPress\Blocks\acf_register_block_type() in /.../Local Sites/foundationpress-mediadudes/app/public/wp-content/themes/FoundationPress/inc/blocks/block-accordion.php on line 16
( ! ) Error: Call to undefined function FoundationPress\Blocks\acf_register_block_type() in /.../Local Sites/foundationpress-mediadudes/app/public/wp-content/themes/FoundationPress/inc/blocks/block-accordion.php on line 16
Call Stack
Time Memory Function Location

1 0.0112 409048 {main}( ) .../customize.php:0
2 0.0112 410320 require_once( '/.../Local Sites/foundationpress-mediadudes/app/public/wp-admin/admin.php' ) .../customize.php:13
3 0.0112 410960 require_once( '/.../Local Sites/foundationpress-mediadudes/app/public/wp-load.php' ) .../admin.php:34
4 0.0113 411400 require_once( '/.../Local Sites/foundationpress-mediadudes/app/public/wp-config.php' ) .../wp-load.php:37
5 0.0113 421688 require_once( '/.../Local Sites/foundationpress-mediadudes/app/public/wp-settings.php' ) .../wp-config.php:77
6 0.1467 3411336 do_action( ) .../wp-settings.php:560
7 0.1467 3411712 WP_Hook->do_action( ) .../plugin.php:484
8 0.1467 3411712 WP_Hook->apply_filters( ) .../class-wp-hook.php:316
9 0.1654 3690224 ACF->init( ) .../class-wp-hook.php:292
10 0.1743 4353656 do_action( ) .../acf.php:325
11 0.1743 4354032 WP_Hook->do_action( ) .../plugin.php:484
12 0.1743 4354032 WP_Hook->apply_filters( ) .../class-wp-hook.php:316
13 0.1743 4355160 FoundationPress\Blocks\Block_Accordion::register_block_type( ) .../class-wp-hook.php:292

There has been a critical error on this website. Please check your site admin email inbox for instructions.
/////////////////////////////////////////////////////
Thank you.

How can this bug be reproduced?

1. Install FoundationPress (Mediadudes) per instructions https://github.com/MEDIADUDES/FoundationPress (quickstart) on Live By Local dev environment (been using it for a couple of years for wordpress site development)
2. run either npm run build or npm run dev
3. Attempt live preview

What did you expect to happen?
Expected to see live preview

What happened instead?
Fatal Error

Please List the Following:

• OS & version: Fedora Core 28 64
• Node version (node -v) [Node v4+ is required] : v10.19.0 & v11.13.0
• FoundationPress version (see line 3 in package.json): "version": "3.4.1", (actually this is in line 4)
• Foundation version (found in node_modules/foundation-sites/package.json) : [email protected]

Include Test Case (if applicable): Don's see how I can do that.
Text output of error:

( ! ) Fatal error: Uncaught Error: Call to undefined function acf_add_options_page() in /../Local Sites/foundationpress-mediadudes/app/public/wp-content/themes/FoundationPress/inc/advanced-custom-fields.php on line 68
( ! ) Error: Call to undefined function acf_add_options_page() in /../Local Sites/foundationpress-mediadudes/app/public/wp-content/themes/FoundationPress/inc/advanced-custom-fields.php on line 68
Call Stack

Time Memory Function Location

1 0.0001 407640 {main}( ) .../customize.php:0
2 0.0001 408912 require_once( '/../Local Sites/foundationpress-mediadudes/app/public/wp-admin/admin.php' ) .../customize.php:13
3 0.0001 409552 require_once( '/../Local Sites/foundationpress-mediadudes/app/public/wp-load.php' ) .../admin.php:34
4 0.0002 409992 require_once( '/../Local Sites/foundationpress-mediadudes/app/public/wp-config.php' ) .../wp-load.php:37
5 0.0003 420280 require_once( '/../Local Sites/foundationpress-mediadudes/app/public/wp-settings.php' ) .../wp-config.php:77
6 0.0364 3261592 do_action( ) .../wp-settings.php:560
7 0.0364 3261968 WP_Hook->do_action( ) .../plugin.php:484
8 0.0364 3261968 WP_Hook->apply_filters( ) .../class-wp-hook.php:316
9 0.0548 3540480 ACF->init( ) .../class-wp-hook.php:292
10 0.0634 4203912 do_action( ) .../acf.php:325
11 0.0634 4204288 WP_Hook->do_action( ) .../plugin.php:484
12 0.0634 4204288 WP_Hook->apply_filters( ) .../class-wp-hook.php:316
13 0.0634 4205416 foundationpress_add_option_pages( ) .../class-wp-hook.php:292
There has been a critical error on this website. Please check your site admin email inbox for instructions.
///////////////////////////////////////////////////////////////////

Repo: https://github.com/phpstan/phpstan