Coder Social home page Coder Social logo

Comments (7)

schalkneethling avatar schalkneethling commented on June 19, 2024

The code sample has "logger.log()" not "console.log()". Is there a reason for this? I'd have thought console would be more obvious.

I changed it to logger. The reason is that should you try to actually .log, .dir or anything like that when debugging the live editor code, this override swallows it :-/

from interactive-examples.

wbamberg avatar wbamberg commented on June 19, 2024

Yes, that makes sense. I don't know if you changed the implementation of console, but in the original it was pretty basic!

from interactive-examples.

wbamberg avatar wbamberg commented on June 19, 2024

I'd like to reopen this. Feedback in our testing in SF was that "logger" was confusing. I think at least we should reconsider whether to use "console".

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

@wbamberg Actually, the way I refactored the code, would allow us to do that now. The problem previously was that the variables and function were all exposed to the global object and so, our console was overriding the global console. I will make this change.

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

No, I take that back. For it to work with the examples it needs to be exposed to the global object which means we will be overwriting the global console :-/

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

Ok, never mind again ;) Turns out there is a way to have the best of both.

from interactive-examples.

schalkneethling avatar schalkneethling commented on June 19, 2024

Resolved in #97

from interactive-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.