mdjnelson / moodle-mod_customcert Goto Github PK

hello,

congratulations for your "custom certificat" which is very useful.

juste some problems with my last update of moodle : 3.1.2+ (no problems before)

• the date doesn't show anymore on the certificat, even if I delete the actual field and create a new...
  see here : http://www.informatique-bureautique.com/moodle/course/view.php?id=63
  in fact, it is ok when I click on "save changes and preview" when modified but not if i click normally on the same certificat in the curse
• on another site, I have the message "invalid id number" and it is no more possible to use them ...
  see here : http://cours.ios.fr/course/view.php?id=2

thank's for your help

At Site administration / ► Plugins / ► Activity modules / ► Custom certificate / ► Manage templates / ► Edit custom certificate, there is an option to load a different template and an option to add a page to an existing template. But there is no option to modify an existing page for an existing template. Here is a screenshot showing the entire form:

This would be a useful feature.

When adding a custom certificate to a course it's possible to choose a name of a template that already exists, which generates the following errors when trying to edit the custom certificate -

Error: mdb->get_record() found more than one record!

line 1539 of /lib/dml/moodle_database.php: call to debugging()
line 1499 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql()
line 1478 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
line 136 of /mod/customcert/classes/edit_form.php: call to moodle_database->get_record()
line 571 of /lib/formslib.php: call to mod_customcert\edit_form->validation()
line 520 of /lib/formslib.php: call to moodleform->validate_defined_fields()
line 617 of /lib/formslib.php: call to moodleform->is_validated()
line 145 of /mod/customcert/edit.php: call to moodleform->get_data()

When I click on get your custom certificate I get the following error Invalid course module ID.

Version: 3.1 release (Build: 2016052302)

Going to get @barbararamiro to have a look at it and see if she can make some improvements.

The downloaded PDF file doesn't open correctly in Acrobat Reader on a Mac or PC. This was initially reported to me by an outside agency that I sent the PDF to for approval. I had been previewing the cert in Preview on a Mac, so I did not realize this. However, I have now verified it on my Mac.

I created the certificate in Moodle 3.1 in Firefox on a Mac. The display issue occurs whether I save and preview the file the from the editor or download the certificate from the activity page. If it would help, I can give you access to the course in a private email.

Attached is a screenshot of what I see in Acrobat Reader and a jpeg of what I see in Preview.

I was told in a Moodle forum there isn't any way to set a background image. The activity developer wrote, "the best solution I can think of is to use an image, but that isn't ideal if all you want is to change the colour. The best solution would be to create another 'background' element that you can choose to add to the certificate (or maybe not an element at all but a setting for the certificate). I need to think about this."

I tried placing a transparent image with no background in the editor. It looked like it was going to work in the browser (see screenshot), but it did not display correctly in the downloaded PDF (also attached).

Certificate_of_Participation-38.pdf

I have been working in Firefox on a Mac and viewing the downloaded PDFs in Preview on a Mac. I will also be creating a separate issue about the PDF not displaying correctly in Adobe Reader under any circumstance.

Hi, I would like to suggest a gridline feature for the "reposition element" page. This would be a very helpful feature to have when repositioning the elements.

For my self when I create a certificate, I figured that repositioning the elements easiest is using an inspection tool (e.g. firebug) and set the "left" and "top" coordinates for an element. This actually works quite well. But most people aren't that technical.

By just dragging the elements, it is at the moment pretty hard to e.g. center a element as well as aligning two elements to be inline with each other. You almost need to put a ruler on your screen to check if it's correct and precise.

Having an option to enable gridlines would make repositioning elements much easier.
Alternatively some kind of a positioning panel could be useful as well to help you positioning the elements.

The current screenshot of the certificate example is not a great advertisement for the plugin. It should really show some top quality certificate that this module can create. Not a MS Word like page written by 8 years old kid ;-)

Hi,
First, Thanks for the module is very useful!
Second, is there a way that the certificate to be emailed to the student (and maybe the teacher) as soon as they meet the requirements, even if they do not click on the certificate?
I think it would be useful functionality.

Thank you in advance!

Hi
I have read several forum threads on adding new fonts and there seems to be some disagreement about what works in the current version of Moodle. Can someone direct me to the most updated documentation for adding fonts.
Thanks.
Todd

Hi,
This is a very nice and useful plugin. (I already translated the English language strings into Mexican Spanish). It will certainly be used a lot at my University site.

I think this plugin will be even nicer if all English language strings were declared as variables, so that they can be translated in AMOS.

The followin strings seem to be hard-wired in English:

Border, Category name, Code, Course name, Date, Grade, Grade item name, Image, Student name, Teacher name, Text, User field

Thanks in advance for your help.

Hello Mark.

Firstly, thanks for your work on this module.

We are on Moodle 3.0. I see recently, the "Position X" and "Position Y" form boxes were removed. ed93542

I guess the thinking was this was confusing and people should use the "Reposition GUI" instead?

Um .... can we have the "Position X" and "Position Y" form boxes back? They allow us to get much finer control than with just the GUI.

Could there maybe be an option to decide if they were shown or not?

Thanks,
James

The label on this button should probably be "Get your certificate" and not mention "custom", which is irrelevant from the perspective of the student. Ideally, the label should be configurable.

Hi

I created a certificate in a test course and gave it a specific name in the edit custom certificate interface. I then deleted the course and all its activities. I then created 15 courses from a template using a course upload file and began the process of renaming the certs in each one. However, the system would not allow me to reuse the cert name from the deleted course. I got an error that said it already exists. It must just exist in a database, because the name is not being used in any other custom cert activity. I am not able to locate an admin panel that would allow me to remove cert names associated with deleted custom cert activities.

Is there any way to do this. I do have access to the databases if need be.

Thanks.

Todd

Investigate.

Mark,

We have not installed the newest version yet, but one of the issues our users pointed out with the original was the lack of sorting or searching in the reports area. In the old version, when using the "view xxxx issued certificates", the list shows up in alpha order by user first name, with only the numeric page method of navigation. Our users would like to be able to sort/choose by first letter of first and/or last name or even search specifically by username.

Thanks for all your work on this project. It is a great addition to Moodle.

This module is amazing and exactly what I am looking for but I cannot get it to display the certificates I get this error and debug code. I have done a lot of Googling and trial and error and unable to get it working. I have the Certificate and SimpleCertificate modules installed, would those be interfering? I hope this plugin is still maintained, it is too awesome to be abandoned! Any advice would be helpful.

Can not find data record in database table customcert_issues.

More information about this error

Debug info: SELECT * FROM {customcert_issues} WHERE userid = ? AND customcertid IS NULL
[array (
0 => '134',
)]
Error code: invalidrecord
Stack trace:
line 1455 of /lib/dml/moodle_database.php: dml_missing_record_exception thrown
line 1431 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
line 45 of /mod/customcert/element/code/classes/element.php: call to moodle_database->get_record()
line 292 of /mod/customcert/classes/template.php: call to customcertelement_code\element->render()
line 127 of /mod/customcert/view.php: call to mod_customcert\template->generate_pdf()

Notes from Juan -

• I find missing the parameters validation at the beginning: params = self::validate_parameters(self::save_element_parameters…
• We usually return a warning structure (even if they are empty) in every WS return function, for deprecation purposes
• Instead require_login you can do a self::validate_context($context); (even for the system context I think that now does a require_login)
• The require_login should not be necessary (all requests have an implicit require_login, except web services with the attribute loginrequired => false in db/services.php)
• Not important at all, instead \external_value we usually do a use external_value; at the begining of the file.

This seems to be a common request.

It would also mean the certificates would not change in the future due to dynamic content as we would serve the saved one.

If a template does not have a teacher selected (due to it being in the system context) it causes an issue when loaded into a course as the field isn't populated. It required editing the field and saving it again so that the teacher field is populated.

Hi Mark,

great job! I like the simplicity. I just find that the buttons "Save changes" and "Save changes an preview" seem associated to the file manager. So at first I wouldn't assume that I should click there.

The same applies for "Template" even though it looks a little more detached from the form.

If the only purpose of the "Upload image" is to select them in the image element, wouldn't it be better to have it in the element directly?

Cheers!
Fred

Hi Mark. Thank you for this great plugin.

A suggestion for the date element, it would be nice to have some extra 'short-date' format to choose between with abbreviated and decimal month-name/number.

Currently there are these available. (what is User date format?)

• February 1, 2000
• February 1st, 2000
• 1 February 2000
• February 2000
• User date format

Extra date format that would be useful to have are for example:

• 1 Feb 2000
• 01.02.2000
• 01/02/2000
• 01-02-2000

Also it would be nice to have an 'Expire' date item to the date element as well. Which would add a date xx days/weeks/years after course completion or issued.

Thanks in advance.

It should be possible in the report to view the certificate for other users (assuming you have the permissions to do so).

When editing elements on reposition page it's possible that it sends the wrong form data to the web service when saving the element, causing it to lose all settings.

Can the sub plugin define?

$plugin->dependencies = array(
    'mod_customcert'  => 2013050100,
);

Is there a way for a student to access all their custom certificates from a single interface rather than having to enter each course separately. I was thinking something like a custom certificate block.

I would also like to be able to run reports of all custom certificates issued across the entire lms. Is this possible?

Thanks.

Todd

It is common for a training organization to maintain a register of certificates, allowing anyone(?) to validate a particular certificate. This implies that certificates have unique IDs, that the ID is printable on the certificate, and that the ID is related to a student record, which is related to a course record. Naturally, merely reprinting or redownloading a certificate does not change the ID.
Adding this functionality would be nice to have.

Hello Mark,
As mod/customcert/element/userfield/lib.php try to include lib/conditionlib.php and to use condition_info::get_condition_user_fields it is no more working with recent Moodle versions.
But as I don't know how conditionlib was working and how core_availability classes are now working I don't know how to upgrade this code. Can you help ? Thanks. Jean-Michel

See MDL-56858.

The appearance in earlier themes prior to Boost made it appear as if the label for the first checkbox was associated with all of them, it was hacky, but did the job. We need to address this properly.

Some nice AJAX search using amd modules.

Hello.
Congratulations for the plugin.
I need to digitally sign certicates.
You think you can use this code [(https://tcpdf.org/examples/example_052)] in a new element?
I'm trying but i could not.
Thank you.

This is because it relies on the user who is editing to have a value for that field as well. We can't rely on this and should display it regardless.

I'm having trouble getting certificate to show in a course. I can add and see it as a preview but when I attempt to generate in a course it comes up blank. I tried uninstall/reinstall, still having the issue. Any ideas?

The help for the Reference point location states "This specifies which location of the element to be located at position X and position Y." However, the options available are "Top right", "center" and "top left". I was under the impression that one of the major points of this plugin is to allow fine tuned and custom positioning of any elements.

This is for version 2016052300 running on Moodle 3.1+ (Build: 20160603)

Currently you have to add another text element to act as the label for an element.

Lets say I add a date element with the name "Completion Date: " and want to use that as a label that outputs to the certificate like 'Completion Date: '.

customcert is suffering of the same problem that certificate has (but to a lesser degree :-) : in some places it is assumed that the current connected user is also the student for whom the certificate has been issued (for instance a lot of elements use $USER).
This is unfortunate because it preclude doing some things
For instance I wanted to write a course report that would permit teachers to view, delete, download issued customcert. But according to my tests this is not possible, for instance the image printed on all customcert is the one of the teacher !
I wanted to report this for some time but I forgot about this. Recent posts on the same subject but for the certificate module reminded me of this.

"The plugin works okay on our site. However there seems to be a bug regarding custom profile field type 'date/time' which doesn't render the date correctly. We have a custom profile field named 'birthday' and it is for our test user '22 April 1964', but this is returned as '-179715600' on the certificate."

Client won't let me upgrade them. grrrrrrrr

I thought I had the mod working. I created 2 templates. Then I tried to add a customcert to a course and it crashed.
Fatal error: Call to undefined method mod_customcert_mod_form::standard_intro_elements() in /var/www/moodle/mod/customcert/mod_form.php on line 48

Mark, do you have a 2.8 compatible version?

You might add help to describe the use of the arrows to reorder the elements in a template and, especially, document that the order in the list determines which elements appear on top of which other elements.

I have the Custom certificate module 3.1 release (Build: 2016052302) in Moodle 3.1.2+ with PHP 7.0 and the drag and drop not work, not change the position the element and not present error message.

I suggest that "rearrange elements" be renamed to "Re-position elements" and that it be put in a button, as is "add another certificate page". This would be much clearer, IMHO.

If you create a site wide template with images and then load it in a course and edit the image element you are not able to see the image that was chosen in the select box. If you then save the image element the image is overwritten.

In Moodle 3.1 the global search feature was added allowing one to search content throughout Moodle. A new API was created allowing modules to utilise this feature - it would be nice if the custom certificate module were to use this API and make use of this new feature.

When you're positioning the elements it's hard to tell similar ones apart from ones that aren't obvious. I'd propose to add the element name to the pop-up modal.

Hi,

I'm looking for a plugin that works like a block verify certificates issued with Custom Certificate.

The plugin Block Verify Certificate doesn't work with Custon Certificate.

The codes issued in Custom Certificate certificates are not recognized in Block Verify Certificate .

Thank you

The PDF preview was offered to me to be opened in Sublime Text. I guess a proper content-type in the HTTP headers would solve this.

Cheers,
Fred

Hi Mark,

I like your custom certificate a lot.

But when I was translating it's sub-plugins into Mexican Spanish, I ran into a problem:

numbersuffix_nd | customcertelement_date 'nd'
numbersuffix_rd | customcertelement_date 'rd'
numbersuffix_st | customcertelement_date 'st'

Which you previously explained to me that are used for '1st', '2nd' and '3rd'... are just too difficult for a non-native English user (such as myself and many other Moodle translators) to guess properly in order to translate accurately.

Would it be too difficult for you to change your code, so as to have Strings for '1st', 2nd' and ...
this one is difficult ... '{$number}th' ?

I realize this is an odd request, but I sincerely think that this would make it so much easier to properly translate your extremely useful plugin into several more languages.

Thanks in advance for your help.

Again, another useful feature.