md-arman-shanto / book-sharing-platform

Personal Django Project

Hi there 👋

book-sharing-platform's Issues

def __unicode__ for python 2 and def __str__ for python 3

Book-sharing-platform/accounts/models.py

Line 21 in 31520d3

#def __unicode__(self):

Please create a readme which describes your project

Your readme should include what the project is about, what technology was used, important commands to run the project, and links to live pages if any.

Please add all common necessary fields in model.py

Common necessary fields are mainly created_at (datetime field, save only once), updated_at (datetimefield, update every time), created_by, updated_by and so on.

Please hide your SECRET_KEY from settings.py. It's a must.

This is critically important. You can create a file named secret_settings.py and place your SECRET_KEY inside this file. Then add this file to .gitignore. Then in your settings, you can remove the secret key variable and import it from there.

Please improve model.py

Preferable attributes and methods order in a model.

• constants (for choices and other)
• fields of the model
• custom manager indication
• meta
• def unicode (python 2) or def str (python 3)
• other special methods
• def clean
• def save
• def get_absolut_url
• other methods

Please note that the given order was taken from documentations and slightly expanded.

Class-based view is recommended

A class-based view allows you to respond to different HTTP request methods with different class instance methods, instead of with conditionally branching code inside a single view function. So, highly recommended.

Please create a .gitignore file

.gitignore file to ignore your pycache files, and other unnecessary files to push in remote repo.