mcspronko / liqpay-magento2 Goto Github PK

What should be done:

• use payment_method_assign_data_pronko_liqpay event
• create an observer to assign data from frontend to payment object

The Pronko_LiqPayWidget extension represents a LiqPay Widget integration (see https://www.liqpay.ua/documentation/api/aquiring/widget/doc)

What should be included as part of this task:

see the checkout directory as an example:

• registration.php
• composer.json
• etc/module.xml

Please add 'pronko_liqpay' into a constant of an interface inside the Pronko_LiqPayApi extension.
Change all occurrences of the string payment method code in the configuration files and PHP classes to use the new constant.

What should be done:

• New payment method with the title "LiqPay Redirect" should be rendered on the checkout payment page
• The payment method should include a billing address and a button "Proceed to LiqPay"

It should be created in the Pronko_LiqPayRedirect extension.

LiqPay Redirect payment method code should be pronko_liqpay_redirect

What should be done:

• Add new configuration settings under Stores -> Configuration -> Sales -> Payment Methods -> LiqPay
• "General Settings" section
  • "Enabled", select field, Yes/No
  • "Title", text field
  • "Mode", select field, Production/Sandbox
• "Account Settings" section
  • "Sandbox Credentials" section
    • "Public Key", text field
    • "Private Key", text field
  • "Production Credentials" section
    • "Public Key", text field
    • "Private Key", text field

https://www.liqpay.ua/documentation/en/api/aquiring/pay/doc

Similar to the PayRequestTest

Running below command is throwing Seld\JsonLint\ParsingException

php composer.phar config repositories.pronko-liqpay [email protected]:mcspronko/liqpay-magento2.git

What should be done:

• TransferFactory class (see \Magento\Payment\Gateway\Http\TransferFactoryInterface) should be created to configure and build the \Magento\Payment\Gateway\Http\TransferInterface instance
• Configure \Magento\Payment\Gateway\Http\Client\Zend class to send the HTTP POST Request with the Pay Transaction to the LiqPay server.

The \Magento\Payment\Gateway\Command\GatewayCommand class should be used to configure Capture command virtual type.

Problem 1
- The requested package pronko/liqpay-magento2 could not be found in any version, there may be a typo in the package name.

The Pronko_LiqPayGateway extension is responsible for Gateway API classes and interfaces for sending a request, validating request and response and processing a response from LiqPay API.

What should be included as part of this task:

• see checkout directory as an example:
  ** registration.php
  ** composer.json
  ** etc/module.xml

Allow having unique order id for testing with LiqPay as it requires us to send unique order_id each time.

This field should be concatenated with order id when sending all LiqPay transaction requests.

The "Order Prefix" and "Order Suffix" fields can be added inside Advanced Settings or Account Settings of the module.

The Config class from the gateway module should be adjusted

Currently, LiqPay only supports a capture transaction.

What should be done:

• Add the "Payment Type" setting to the configuration to the Pronko\LiqPayAdmin module
• The setting should include 2 standard options "Authorize Only" and "Authorize and Capture"
• Implement Builders to support Authorization transaction

What should be done:

• Card Number, Exp Year, Exp Month and CVV values should be passed from Payment object to the CardPaymentBuilder.

Documentation: https://www.liqpay.ua/documentation/en/api/aquiring/checkout/doc

Keys:
amount and currency

The di.xml file should be adjusted with the configuration for the redirect CommandPool virtual type.

Please check https://www.liqpay.ua/documentation/en/api/aquiring/pay/doc for year format.

[2019-08-30 06:05:51] main.DEBUG: array (
  'request_raw' => 
  array (
    'data' => 
    array (
      'version' => 3,
      'public_key' => '',
      'action' => 'pay',
      'description' => 'LiqPay for Magento 2',
      'order_id' => '000000098',
      'card' => '4000000000000002',
      'card_cvv' => '111',
      'card_exp_month' => '1',
      'card_exp_year' => '2021',
      'amount' => 53.71,
      'currency' => 'USD',
      'phone' => '(555) 229-3326',
    ),
    'signature' => '',
  ),
) [] []

[2019-08-30 06:05:51] main.DEBUG: array (
  'request_uri' => 'https://www.liqpay.ua/api/request',
  'response' => 
  array (
    'result' => 'error',
    'action' => 'pay',
    'status' => 'failure',
    'err_code' => 'err_wrong',
    'err_description' => 'Invalid parameter card_date',
    'version' => 3,
    'type' => 'buy',
    'public_key' => 'sandbox_i70710739841',
    'liqpay_order_id' => '000000098',
    'description' => 'LiqPay for Magento 2',
    'amount' => 53.71,
    'currency' => 'USD',
    'is_3ds' => false,
    'key' => 'card_date',
    'code' => 'err_wrong',
  ),
) [] []

What should be done:

• Payment form should be created using UI Component (JS and HTML files) and added via checkout_index_index.xml file
• Payment form should include a LiqPay title
• Payment form should have the following fields:
  • Card Number
  • Expiration Month
  • Expiration Year
  • CVV code
• Place Order button

What should be done:

• getPrivateKey() method should return value from either payment/pronko_liqpay/sandbox_private_key or payment/pronko_liqpay/production_private_key depending on the Envrionment value Sandbox or Production.
• same logic for getPublicKey should be implemented

What should be done:

• Customer should see Card Number 42****4242, Exp Date

Maxs-MacBook-Pro:liqpay-magento2 pronko$ composer test-phpcs

vendor/bin/phpcs --standard=Magento2 ./checkout/ ./test/ ./admin/ ./card-gateway/ ./gateway/ ./redirect/ ./customer/ ./widget/ ./api/

FILE: ...y-magento2/card-gateway/Test/Integration/Gateway/RequestTest.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

102 | WARNING | Code must not contain multiple empty lines in a row;
| | found 2 empty lines.

FILE: ...nto2/card-gateway/Gateway/Request/Builder/CardPaymentBuilder.php

FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES

49 | WARNING | Line exceeds maximum limit of 120 characters;
| | contains 155 characters
50 | WARNING | Line exceeds maximum limit of 120 characters;
| | contains 152 characters

FILE: ...ions/liqpay-magento2/api/Api/Data/PaymentMethodCodeInterface.php

FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES

11 | WARNING | [x] Expected 1 space(s) before asterisk; 0 found
12 | WARNING | [x] Expected 1 space(s) before asterisk; 0 found

PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY

See CardPaymentBuilder class, the amount value.

The Pronko_LiqPayRedirect extension represents the LiqPay Checkout integration (see https://www.liqpay.ua/documentation/api/aquiring/checkout/ page) which redirects a customer to a LiqPay server with a payment form.

What should be included as part of this task:

see the checkout directory as an example:

• registration.php
• composer.json
• etc/module.xml

The Pronko_LiqPayAdmin extension is responsible for rendering configuration of the LiqPay payment method.

What should be included as part of this task:

• see checkout directory as an example:
  ** registration.php
  ** composer.json
  ** etc/module.xml

What should be done:

• The settings for the LiqPay payment method should be created:
  • Under General Settings section
    • Payment Action, select field, Options: Authorize Only (value authorize), Authorize and Capture (Pay) (value authorize_capture)
  • new section "Card Payment" - should be created in the scope of the card-admin module (Pronko_LiqPayCardAdmin)
    • Card Types, multi-select field, options: Visa, Mastercard
• Advanced Settings
  • Minimum Order Total, text field
  • Maximum Order Total, text field
  • Sort Order, text field
  • New Order Status, select field, default Processing
  • Accepted Currencies, multi-select field, options - USD, EUR, RUB, UAH

https://www.liqpay.ua/documentation/en/api/callback