mcrossen / deepsort Goto Github PK

it would be useful to add a feature that allows hashes to be deep merged. duplicate keys wouldn't be overwritten, the values would be merged.

I have some code that serializes both Hash and Array objects as YAML.

I had originally written:

data = data.deep_stringify_keys if data.respond_to?(:deep_stringify_keys)
data = data.deep_sort if data.respond_to?(:deep_sort)

This is fine for Hash, since the YAML spec specifies that order in mappings is a serialization detail.

But of course deepsort also adds deep_sort to Array, which is not a serialization detail.

I ended up changing the code to check .is_a?(Hash)

data = data.deep_sort if data.is_a?(Hash)

but it would have been nice if there were a way to only patch Hash and not Array when using deepsort.

Ruby 1.8.7

#!/usr/bin/ruby

require 'pp'
require 'rubygems'
require 'deepsort'

nested = {"z" => 4, "b" => 3, "a"=>[2, 1] }
nested.deep_sort
pp nested # sorts in place without the `!`?

nested = {"z" => 4, "b" => 3, "a"=>[2, 1] }
pp nested.deep_sort # prints the original array

Result:

{"a"=>[2, 1], "b"=>3, "z"=>4}
{"z"=>4, "b"=>3, "a"=>[1, 2]}

I'd prefer to use Deepsort.sort(hash) ... would you accept a PR to make this available ?
... what are you thoughts about making that the default and having a separate file like deepsort/ext do the patching ?

@mcrossen

this may require adding map! and each! to Hash in a clever way