Coder Social home page Coder Social logo

Comments (4)

sp614x avatar sp614x commented on July 27, 2024

The transformers currently have no own IDs and there may be several transformers per transformation service (which has an ID). This means that transformers can't be uniquely identified.
Switching to one transformer per service or adding transformer IDs could fix this.

from modlauncher.

cpw avatar cpw commented on July 27, 2024

The second concern: around "init" would be better solved by modifying the TransformationService itself. If you need a different set based on environmental factors, both initialize and onLoad are called prior to ModLauncher fetching the list of transformers. If there is insufficient information in those methods (and the Environment they receive) then we can look at extending both of them. In fact, the environment will be how you tell FML/Forge that you exist. I'm going to add a standard "Modifier" hook where you can add any mod information you wish.

from modlauncher.

cpw avatar cpw commented on July 27, 2024

Please review the 3.x versions of modlauncher. Should be good to go. Suggest validating that you're in that version by checking the api package's specificationversion, before doing anything else.

from modlauncher.

Technici4n avatar Technici4n commented on July 27, 2024

Should be good, as cpw said 4 years ago. :)

from modlauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.