Comments (4)
The transformers currently have no own IDs and there may be several transformers per transformation service (which has an ID). This means that transformers can't be uniquely identified.
Switching to one transformer per service or adding transformer IDs could fix this.
from modlauncher.
The second concern: around "init" would be better solved by modifying the TransformationService itself. If you need a different set based on environmental factors, both initialize and onLoad are called prior to ModLauncher fetching the list of transformers. If there is insufficient information in those methods (and the Environment they receive) then we can look at extending both of them. In fact, the environment will be how you tell FML/Forge that you exist. I'm going to add a standard "Modifier" hook where you can add any mod information you wish.
from modlauncher.
Please review the 3.x versions of modlauncher. Should be good to go. Suggest validating that you're in that version by checking the api package's specificationversion, before doing anything else.
from modlauncher.
Should be good, as cpw said 4 years ago. :)
from modlauncher.
Related Issues (20)
- Service Providers are not properly propagated to children HOT 3
- ModuleLayerHandler.getLayer throws NPE if layer is missing HOT 15
- GAME layer resources returned from beginScanning are ignored HOT 1
- How to use for own game? HOT 2
- TransformationServices cannot add classes or resources. HOT 1
- Vanilla command line arguments inaccesible
- INameMappingService isn't exposed in API jar HOT 1
- Not compatible with Java 16 HOT 3
- OpenJ9 detection fails for certain builds of the VM HOT 1
- Readme needs updating
- Cannot get jdk class byte from ITransformerLoader HOT 1
- Need to reimplement test harness and testing paradigm if we stick with modular setup HOT 1
- Unable to transform class related to record. HOT 8
- `ClassCastException` due to transformers that implement nonparameterized interfaces HOT 3
- [NPE] Cannot invoke "joptsimple.OptionSet.valueOf(joptsimple.OptionSpec)" because "this.optionSet" is null HOT 1
- Broken feature: ITransformationService::additionalClassesLocator
- Allow registering additional packages in the transformable layer for generated classes HOT 3
- Incompatibility between modlauncher 8.1.x (mc 1.16) and Java 8 u321+ HOT 7
- Modlauncher can't detect interfaces of transformer parents HOT 2
- TransformerDiscoveryService not recognized HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modlauncher.