Coder Social home page Coder Social logo

Comments (3)

cpw avatar cpw commented on July 27, 2024

Yes, this might be a way to address the additional classes issue as well.

from modlauncher.

marchermans avatar marchermans commented on July 27, 2024

We might need to create a proper API which queries the transformers when the modules are created, and asks if they wish to add packages to each module.
Then we could track those and if we notice that we are in such a package during class loading immediately redirect to the Transformer in question?

from modlauncher.

Su5eD avatar Su5eD commented on July 27, 2024

We could add a new Map<String, Set<String>> additionalPackages() method to ITransformationService that would return a map of module names to package names. Before the transformable layer is built, modlauncher would query each transformation service for additional packages, and merge the maps. The resulting package names would then be routed into JarMetadata#descriptor by JarModuleFinder.

Then we could track those and if we notice that we are in such a package during class loading immediately redirect to the Transformer in question?

A possible way could be overriding getClassBytes in TransformingClassLoader and returning an empty array if the package is provided by a transformation service. However, we'd have to expose packageLookup for getting module names, as well as ensuring additional packages don't contain existing package names.
Not sure whether it's worth the effort as it wouldn't really improve performance.

from modlauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.