Comments (3)
Yes, this might be a way to address the additional classes issue as well.
from modlauncher.
We might need to create a proper API which queries the transformers when the modules are created, and asks if they wish to add packages to each module.
Then we could track those and if we notice that we are in such a package during class loading immediately redirect to the Transformer in question?
from modlauncher.
We could add a new Map<String, Set<String>> additionalPackages()
method to ITransformationService
that would return a map of module names to package names. Before the transformable layer is built, modlauncher would query each transformation service for additional packages, and merge the maps. The resulting package names would then be routed into JarMetadata#descriptor
by JarModuleFinder
.
Then we could track those and if we notice that we are in such a package during class loading immediately redirect to the Transformer in question?
A possible way could be overriding getClassBytes
in TransformingClassLoader
and returning an empty array if the package is provided by a transformation service. However, we'd have to expose packageLookup
for getting module names, as well as ensuring additional packages don't contain existing package names.
Not sure whether it's worth the effort as it wouldn't really improve performance.
from modlauncher.
Related Issues (20)
- Service Providers are not properly propagated to children HOT 3
- ModuleLayerHandler.getLayer throws NPE if layer is missing HOT 15
- GAME layer resources returned from beginScanning are ignored HOT 1
- How to use for own game? HOT 2
- TransformationServices cannot add classes or resources. HOT 1
- Does it work on Java 8 or not??? HOT 3
- INameMappingService isn't exposed in API jar HOT 1
- Not compatible with Java 16 HOT 3
- OpenJ9 detection fails for certain builds of the VM HOT 1
- Readme needs updating
- Cannot get jdk class byte from ITransformerLoader HOT 1
- Need to reimplement test harness and testing paradigm if we stick with modular setup HOT 1
- Unable to transform class related to record. HOT 8
- `ClassCastException` due to transformers that implement nonparameterized interfaces HOT 3
- [NPE] Cannot invoke "joptsimple.OptionSet.valueOf(joptsimple.OptionSpec)" because "this.optionSet" is null HOT 1
- Broken feature: ITransformationService::additionalClassesLocator
- Incompatibility between modlauncher 8.1.x (mc 1.16) and Java 8 u321+ HOT 7
- Modlauncher can't detect interfaces of transformer parents HOT 2
- TransformerDiscoveryService not recognized HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modlauncher.