Coder Social home page Coder Social logo

Comments (2)

cpw avatar cpw commented on July 27, 2024 2

Should be fixed with new forge and modlauncher APIs.

from modlauncher.

ichttt avatar ichttt commented on July 27, 2024

I just watched some parts of your stream and want to clarify some things:

  • The numbers I got where from running forge to the main menu with the code block I mentioned in my forge PR.
  • There were actually two optimizations in my modlauncher PR: skipping the whole transformer step if only plugins are transforming (from Line 52 to Line 71) which I think you didn't pick up. This is badly readable in the git diff though.
  • I think another optimisation with quite some impact would be to ask plugins for their needed ClassWriter flags, so if there is any transformer preset, use that COMPUTE_FRAMES, otherwise use the highest level that resulted from the plugins that actually wrote (as e.g. the object_holder_definalize needs no writing flag). Could be a new method on ILaunchPluginService. Currently this is hardcoded here

Anyways, thanks for doing this the proper way and making actual benchmarks. Hopefully I can join next stream

from modlauncher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.