mcartoixa / connect-tedious Goto Github PK

Hi,

First of all At line 188 it should be

'DELETE s FROM ' + self.tableName + ' s WHERE s.' + self.sidColumnName + '=@sid',

While calling req.session.destroy, it infact creates a new session row with new sessionid but why the old session row are not being deleted even there is sql statement being executed.

PS: How can I access other methods req.session.length(), req.session.get() all prducess #session(object) method not found.

The debug module dependency is not declared in the package.json

The readme instructs developers to pass express to connect-tedious:

var express = require('express');
var TediousStore = require('connect-tedious')(express);

In version 4.x, Express removed all built-in middleware from its core except express.static. So the documentation should read:

var express = require('express');
var session = require('express-session');
var TediousStore = require('connect-tedious')(session);

Not sure if you still want to support Express 3 -- at the very least include a note in the readme about Express 4 and express-session?

In the dbCleanUp function, fn is not defined. Maybe add this callback to the function parameters.