mc12345678 / user_tracking Goto Github PK

15 chars is too short for current IP addresses. IP _address fields in admin table are varchar(45)

last_page_url and referer_url cannot be null triggered by [SQL injection hacker]
in
includes/classes/observers/class.user_tracking.php on line 135

Change ln119 ln122 so
$wo_last_page_url and $referer_url both have a default value if null

$wo_last_page_url = substr($wo_last_page_url, 0, 125) ?? 'default';
$referer_url = substr($referer_url, 0, 253) ?? 'default';

I'm getting names like
drmons0552w-134-41-130-103.dhcp-dynamic.fibreop.ns.bellaliant.net
which don't it into the existing field.

While trying to remove hard coded text, created an expected define without incorporating into language file(s).

Identified in the forum: https://www.zen-cart.com/showthread.php?35081-User-tracking-mod&p=1377407#post1377407, there are now catalog pages that do not have NAVBAR_TITLE defined which in newer versions of PHP will generate at least warning eventually to lead to errors.

Instead of expecting that there is such a definition in a default store, changing this to simply evaluate for presence and provide blank for absence of data...

After installation of Version 1.5.9 to ZC 1.5.7b, when attempting to "view" the user tracking history of a session, had a myDEBUG-adm file generated and was logged out of the admin:

[DATE TIME TIMEZONE] Request URI: /admin/index.php?cmd=user_tracking, IP address: IP_ADDRESS
#1  session_decode() called at [/PATH_TO_STORE/admin/user_tracking.php:778]
#2  require(/PATH_TO_STORE/admin/user_tracking.php) called at [/PATH_TO_STORE/admin/index.php:11]
--> PHP Warning: session_decode(): Failed to decode session object. Session has been destroyed in /PATH_TO_STORE/admin/user_tracking.php on line 778.

[DATE TIME TIMEZONE] Request URI: /admin/index.php?cmd=user_tracking, IP address: IP_ADDRESS
#1  session_decode() called at [/PATH_TO_STORE/admin/user_tracking.php:787]
#2  require(/PATH_TO_STORE/admin/user_tracking.php) called at [/PATH_TO_STORE/admin/index.php:11]
--> PHP Warning: session_decode(): Session is not active. You cannot decode session data in /PATH_TO_STORE/admin/user_tracking.php on line 787.

The code of the Zen Cart's who's online is able to provide the desired information without this issue. The hint may be in the associated class file that may also allow stepping away from individual code within the plugin and depend even more on ZC's code.

Line 390 of admin/user_tracking.php includes code that was "commented out" from the previous version; however, is not made to display as would be expected for its placement. It should either be removed or if desired to still be a placeholder made to be pushed to the browser rather than parsed as php.

myDebug file possibly generated.