mberneti / kavenegar.core Goto Github PK

Hello,
Unfortunately your package targets only .net standard.
I'm working on new version with some improvements which targets .netcoreapp2.1 framework.

in your main class (KavenegarApi.cs) an HttpClient is instantiated in the contructor, which means with every single sms send request through this class, a new HttpClient is created, as you may know, HttpClient is not supposed to be instantiated for each request.
here you can read about HttpClient possible flaws. From documents:

HttpClient is intended to be instantiated once and re-used throughout the life of an application. Instantiating an HttpClient class for every request will exhaust the number of sockets available under heavy loads. This will result in SocketException errors. Below is an example using HttpClient correctly.

So, I suggest that you add an overload constructor to the class which takes the HttpClient from the outside. This way it could be injected like a Typed client