mbattyani / cl-typesetting Goto Github PK

Hi,

In hyphenation-fp.lisp, I recommend changing the defpackage :cl-typesetting-hyphen to the following:

(defpackage :cl-typesetting-hyphen
  (:use common-lisp)
  (:nicknames :cl-tt-hyph)
  (:export #:language-defined-p
	   #:define-language
	   #:language-loaded-p
	   #:load-language
	   #:language-hyphenation))

Otherwise the uppercase strings will break modern-mode Lisps such as Allegro CL mlisp.

Regards,

Dave

Given this example:

(pdf:with-document ()
  (pdf:with-page ()
    (pdf:with-outline-level ("1" (pdf:register-page-reference))
      (let ((result (tt:compile-text ()
                      (tt:table (:border 1 :border-color "#c00000"
                                 :padding 0  :cell-padding 6
                                 :col-widths (list 100 200))
                        (tt:row ()
                          (tt:cell () "foo bar baz" :eol "hooray")
                          (tt:cell (:v-align :center) "some more text"))))))
        (tt::draw-block result 50 160 480 100))))
  (pdf:write-document "/tmp/aaaa.pdf"))

I observe that the vertical size resp. alignment isn't fully correct (padding below is bigger than above, so the :v-align :center is off-center), and the :border-color isn't respected.

Thanks for your help!

In test.lisp the test multi-page-example triggers the error cannot-fit-on-page with message "Unable to fit even on a new page.". It appears that the while condition that checks whether there are boxes in the content left is true, but the boxes are only two text styles (the latter with all values to nil). This does not result in boxes when (fit-lines content ...) is applied, thus triggering the error (all this in draw-pages in top-level.lisp).

The same issue occurs when trying to generate the documentation pdf. A simple workaround is to simply remove the trigger of the error, but this gives an extra page in the documentation pdf, for example.