maximilionus / monokai_pro_keygen

Monokai Pro theme license key generator for Visual Studio Code and Sublime Text

monokai_pro_keygen's Issues

Email regex check should be enhanced

It's definitely shouldn't be implemented on user-interaction layer

monokai_pro_keygen/keygen.py

Line 67 in f1d45e7

email_regex = re.compile(r'\b[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Z|a-z]{2,}\b')

monokai_pro_keygen/keygen.py

Lines 93 to 94 in f1d45e7

	elif not email_regex.match(selected_email):
	__print_action("provide the valid email address", is_failure=True)

Email regex check should be implemented as standalone function that will be used in more low-level functions like

monokai_pro_keygen/keygen.py

Lines 12 to 20 in f1d45e7

	def keygen_vscode(email: str) -> str:
	"""
	Keygen for Visual Studio Code
	:param email: valid email address
	:type email: str
	:return: generated key for theme activation
	:rtype: str
	"""

monokai_pro_keygen/keygen.py

Lines 27 to 35 in f1d45e7

	def keygen_sublime(email: str) -> str:
	"""
	Keygen for Sublime Text 3
	:param email: valid email address
	:type email: str
	:return: generated key for theme activation
	:rtype: str
	"""