maudigan / charbrowser Goto Github PK

GetItem() in include/item.php needs to be rewritten from the ground up. The way modern clients display the items has changed drastically since this was written.

The custom external links are set in the config file. By default they direct to mqemulator.

If a server op wants them to point locally or to another site they can alter those links in the config file. Most server operators do not do this though. The config file is suffixed with .template so that it won’t overwrite the server operators modified one which has a .php extension.

This means that when changes are made to the links in the .template, e.g. if mqemulator renames a script so the config links change, the server operators likely won’t get the updated changes. Or, they will have to manually intervene and copy the new links over. That’s good for servers whom have modified their links, but bad for servers using the default links.

This should be rewritten for those links to be blank in the config file. If a server operator changes them they will get used, but if they remain blank they should, in a common, easily updated location, revert to the default. That way a sever using the default will get updates, but those updates won’t screw up a server that uses custom links. It might make sense to do something similar for other settings in the config as well.

#charbrowser.bagbuttonrow(s) have invalid top properties, the number is missing the 'px'