mattwelke / apache-openwhisk-runtime-java-17

Experimental runtime for Apache OpenWhisk. Not considered production ready. Not affiliated with the Apache Software Foundation.

apache-openwhisk-runtime-java-17

An experimental runtime for Apache OpenWhisk. Derived from https://github.com/apache/openwhisk-runtime-java.

Not considered production ready. Not affiliated with the Apache Software Foundation.

Not maintained as of Jan 7, 2023.

apache-openwhisk-runtime-java-17's Issues

Switch to Adoptium JDK for runtime

Right now, it's using jlink to produce a runtime. Normally, one would use jlink to produce a runtime as small as possible, including only the modules needed by their app's code. However, OpenWhisk users may have any use case, so that's why the current Dockerfile attempts to include every module.

For simplicity, we may as well just use a JDK instead of a custom runtime. Even modules including things like compiler tools may be useful for niche use cases that OpenWhisk users may have.

Additionally, the Dockerfile still contains copy-pasted code from when I experimented with jlink using Microsoft tutorials. We should switch from a Microsoft build to an Adoptium build (https://adoptium.net/) because it will be more likely to be recognized and understood by OpenWhisk users.

Break apart GHA workflow

Right now, the GHA workflow does the build and push to Docker Hub, and it's running on pull request. Instead, we need two workflows:

• test - runs tests upon pull requests to main
• build_and_deploy - builds the Docker image and deploys it to Docker Hub upon pushes to main

That way we won't have pull requests causing Docker Images to be built and we'll have something in place to run tests.

Remove setClusterContext

In https://github.com/ow-extended-runtimes/java-17/blob/main/src/main/java/com/owextendedruntimes/actiontest/Action.java, the method setClusterContext is problematic. It's weird that users would see that function because they shouldn't call it. It's only there so that the Proxy can inject the cluster context during setup for the action to reference during any invocation it wants to. Right now, the method is public because it exists in a different package from the Proxy class.

Solutions:

• Move into the same package as the Proxy class, so that the visibility can be changed to package-private. That way, users won't see it.
• Refactor the Action class and Proxy class. In the Action class, add a constructor that allows the context to be injected. In the Proxy class, use reflection to call the new constructor instead of calling the default constructor like right now.