mattusifer / s3ed Goto Github PK

Hi there @mattusifer,
First of all, thanks for this package. It's been super useful for me on a daily basis.

Since the last time I updated, I'm running into an issue with s3ed-mode which breaks the backspace key on the minibuffer for everything else.
Steps to reproduce:

• call s3ed-find-file.
• answer y to the prompt.
• visit a bucket.

Once that is done, the problem is now activated. Whenever I'm trying to use the minibuffer for any other reason (say, good old C-x C-f), if I hit backspace I get the following error:

Debugger entered--Lisp error: (void-variable base)
  #f(compiled-function () (interactive nil) #<bytecode 0xb4797c153aeae80>)()
  funcall-interactively(#f(compiled-function () (interactive nil) #<bytecode 0xb4797c153aeae80>))
  call-interactively(#f(compiled-function () (interactive nil) #<bytecode 0xb4797c153aeae80>) nil nil)
  command-execute(#f(compiled-function () (interactive nil) #<bytecode 0xb4797c153aeae80>))
  read-from-minibuffer(...)
  completing-read-default(...)
  completing-read(...)
  read-file-name-default(...)
  read-file-name(...)
  find-file-read-args(...)
  byte-code(...)
  call-interactively(find-file nil nil)
  command-execute(find-file)

Clicking on the compiled function on the second like shows this:

byte code:
  args: nil
 interactive: nil
0       constant  s3ed-completing-read-backspace
1       varref    base
2       call      1
3       return    

This is a very helpful tool for my workflow so thanks for making it!

I need to copy content with --sse flag every time I copy content but not sure how to specify this or other flags. I understand you can't make everything flexible because I could just use AWS CLI directly but any way to modify the command before it's run to add arguments or customize variable with flags I always need to use?

The title says it all. It would be nice as then editing files in s3 would be integrated everywhere in Emacs.

Thanks a lot for working on this module!
I think support for using different accounts/profiles and regions would be a big plus.
Eg have the path start with /profile/region/
Then it can be different for each interaction with s3 without much hassle.

The fix for #26 works great as long as you complete the s3ed command. I've found that if you change your mind and quit (C-g), the backspace binding remains and causes an error for other minibuffer commands.

I commented on #27 with a workaround: I am advising the s3ed commands to handle the quit signal:

(defun my/s3ed-quit-handler (orig &rest args)
  (condition-case nil
      (apply orig args)
    (quit (define-key minibuffer-local-map (kbd "<backspace>") nil))))
(advice-add #'s3ed-find-file :around #'my/s3ed-quit-handler)
(advice-add #'s3ed-save-file :around #'my/s3ed-quit-handler)

This project looks really cool, so I tried to install via my spacemacs config, but it looks like there isn't a package yet on MELPA or spacelpa.