mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom

Hey friend 👋

I wrote my first HTML and CSS in 2001 and I've been living the webmaster's dream ever since. 😎

atom-ember-snippets's Issues

Await tests helpers

Now it makes sense to put await before every helper as they are async Promises

atom-ember-snippets/snippets/ember.cson

Lines 332 to 360 in 99eb8cd

	'visit(...)':
	'prefix': 'visit'
	'leftLabel': 'Ember'
	'body': "visit('${1:url}');"
	'fillIn(...)':
	'prefix': 'fill-in'
	'leftLabel': 'Ember'
	'body': "fillIn('${1:selector}', '${2:text}');"
	'click(...)':
	'prefix': 'click'
	'leftLabel': 'Ember'
	'body': "click('${1:selector}');"
	'keyEvent(...)':
	'prefix': 'key-event'
	'leftLabel': 'Ember'
	'body': "keyEvent('${1:selector}', '${2:type}', '${3:keyCode}');"
	'triggerEvent(...)':
	'prefix': 'trigger-event'
	'leftLabel': 'Ember'
	'body': "triggerEvent('${1:selector}', '${2:type}', '${3:options}');"
	'find(...)':
	'prefix': 'find-element'
	'leftLabel': 'Ember'
	'body': "find('${1:selector}', '${2:context}');"

How do I use these snippets?

In installed the package, both through apm and in-tool, restarted Atom twice, but still am not getting say the eachelse snippet to pop up in an .hbs file.

I've tried with the language set to HTMLBars and Ember HTMLBars.

3.0.0 issue

Failed to load snippets from '/Users/maciej/.atom/packages/ember-snippets/snippets/ember.cson'

ember cli shims

Hi would you want to migrate your snippets to be ember-cli-shims format ?

so instead of

import Ember from 'ember'

export default Ember.component.extend({

})

it would be

import Component from 'ember-component'

export default Component.extend({

})

Typescript compatibility

Wouldn't it be nice for those snippets to work in .ts files?

Simply replacing '.source.js': with '.source.js, .source.ts': in the snippets decalration files should do the trick I suppose.

Use package-deps to explicitly declare atom-handlebars as dependancy

https://github.com/steelbrain/package-deps

Please update Changelog

Your current Changelog only lists up to version 0.3.0 - you're currently on 0.9.5. Please update your Changelog with all historical, relative changes. Thank you.

best,

— faddah wolf
portland, oregon, u.s.a.
github.com/faddah

No destructuring?

I did the destructuring thing for a while (const { Component } = Ember;) but it seems to have fallen out of favor. Wondering if we could/should switch back to Ember.Component, like in the guides?

Also I just saw this tweet: https://twitter.com/MiguelCamba/status/884724694871666688. It would be nice to add these soon, but I'm not sure about what they depend on.

Update Model snippet

Import of DS.Model should be changed to import Model from 'ember-data/model';

atom-ember-snippets/snippets/file-skeletons.cson

Lines 104 to 113 in 99eb8cd

	'Model Skeleton':
	'prefix': 'model'
	'leftLabel': 'Ember'
	'body': """
	import DS from 'ember-data';
	export default DS.Model.extend({
	\t${1:// body}
	});
	"""

Remove Logger snippets

We should remove all Logger references as it has been deprecated in favor of console
https://www.emberjs.com/blog/2018/07/02/ember-3-2-released.html#toc_use-of-ember-logger-1-of-3

atom-ember-snippets/snippets/ember.cson

Lines 301 to 326 in 99eb8cd

	# Logger
	#
	'Logger.debug(...)':
	'prefix': 'logger-debug'
	'leftLabel': 'Ember'
	'body': "Logger.debug('${1:message}');"
	'Logger.log(...)':
	'prefix': 'logger-log'
	'leftLabel': 'Ember'
	'body': "Ember.Logger.log('${1:message}');"
	'Logger.info(...)':
	'prefix': 'logger-info'
	'leftLabel': 'Ember'
	'body': "Ember.Logger.info('${1:message}');"
	'Logger.warn(...)':
	'prefix': 'logger-warn'
	'leftLabel': 'Ember'
	'body': "Ember.Logger.warn('${1:message}');"
	'Logger.error(...)':
	'prefix': 'logger-error'
	'leftLabel': 'Ember'
	'body': "Ember.Logger.error('${1:message}');"

Support ember-decorators package's import statements

Hey,

As Ember marketing team is generating buzz around Ember Octane Edition, many users are trying out Ember's new features. It would be awesome to allow users autocomplete ember-decorators's import statements to make user's experience better.

Ember Decorators API Documentation:
https://ember-decorators.github.io/ember-decorators/

Module	Import	File
component	import { ... } from '@ember-decorators/component'	import-ember-decorators-component.cson
controller	import { ... } from '@ember-decorators/controller'	import-ember-decorators-controller.cson
data	import { ... } from '@ember-decorators/data'	import-ember-decorators-data.cson
object	import { ... } from '@ember-decorators/object'	import-ember-decorators-object.cson
object/computed	import { ... } from '@ember-decorators/object/computed'	import-ember-decorators-object/-omputed.cson
service	import { ... } from '@ember-decorators/service'	import-ember-decorators-service.cson

• All ember-decorators import statements will have imdec prefix.
• All ember-decorators import statements will be distinguish by #EDAE49 color. See Preview

i.e.

snippets/import-ember-decorators-object.cson

'Ember.object.computed':
  'prefix': 'imdeccomputed',
  'leftLabelHTML': '<span style="color:#EDAE49">Ember Decorators module</span>',
  'body': "import { className } from '@ember-decorators/component;'"

If you are okay with supporting ember-decorators's import statements in this plugin, I can send you PR.

Change pauseTest snippet

await pauseTest() should be changed to await this.pauseTest() as its assigned to context thanks to: https://github.com/emberjs/ember-qunit#setup-tests

Thanks to that, this call is more popular when debugging test

atom-ember-snippets/snippets/ember.cson

Lines 362 to 367 in 99eb8cd

	'await pauseTest(...)':
	'prefix': 'pause'
	'leftLabel': 'Ember'
	'body':"""
	await pauseTest();
	"""

Add ember-data imports snippet

We should add snippets for all those modern imports:

• immodel
• imadapter
• imtransform
• imserializer
• imattr
• imhasMany
• imbelongsTo

import Model from 'ember-data/model';
import Adapter from 'ember-data/adapter';
import Transform from 'ember-data/transform';
import Serializer from 'ember-data/serializer';

import attr from 'ember-data/attr';
import { hasMany } from 'ember-data/relationships';
import { belongsTo } from 'ember-data/relationships';

imisHtmlSafe write incorrect code

The snippet imisHtmlSafe is generating

import { isHtmlSafe } from '@ember/string';

but this code makes build fail. The correct code is:

import { isHTMLSafe } from '@ember/string';

Thanks.

Improve inject.service snippet

as iminjectService adds: import { inject as service } from '@ember/service'; it makes sense to change this snippet to just service(${1}),

atom-ember-snippets/snippets/ember.cson

Lines 66 to 69 in 99eb8cd

	'inject.service(...)':
	'prefix': 'inject'
	'leftLabel': 'Ember'
	'body': 'inject.service(${1}),'

module imports do not appear to work on ember-cli-babel 6.12.0

Running in a ember-cli project that has ember-cli-babel v6.12.0 installed, I am not getting any autocomplete suggestions for ember module imports. However, on an older project, running 6.6.0, they are working fine.

If you need any additional environment info in order to debug this, just let me know.

Follow editor's indent rule

Currently all snippets have fixed indents of 2 spaces which can be annoying when you have Atom configured to use 4 spaces or even hard tabs.

If the indents in snippets use hard tabs then Atom will auto-convert using the configured rule when inserting. See zenorocha/atom-javascript-snippets#15 for a similar issue/fix in another snippets package.

Add LET helper to templates snippets

It would be useful to add new let helper snippet
REF: https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md

atom-ember-snippets/snippets/handlebars.cson

Line 3 in 99eb8cd

# handlebars

Space between closing paren and bracket

Thanks for picking up maintenance of this lib :)

Style bikeshed, how do you feel about adding a space after the parens in the method signatures?

-  didRender(){
+  didRender() {
     this._super(...arguments);
    
   },

I'd be happy to take over this project

I've been using this repo plus a bunch of other snippets I've been maintaining for a while. If you're looking for a maintainer, I'd be happy to offer my services!

Duplicate `Helper Skeleton`

Atom: 1.25.0-beta2

.atom/packages/ember-snippets/snippets/file-skeletons.cson: Duplicate key 'Helper Skeleton'