matthiasnoback / convenient-immutability Goto Github PK

Don't understand why CI does not fail. This is TransformationFailedException in form because of integer values in choices.

There was 1 failure:

1. ConvenientImmutability\Test\FormIntegrationTest::it_works_with_a_standard_use_case_for_command_objects
   Failed asserting that two objects are equal.
   --- Expected
   +++ Actual
   @@ @@
   ConvenientImmutability\Test\Resources\OrderSeats Object (
   '_defaultValues' => Array (...)
   '_userDefinedValues' => Array (
   'id' => Ramsey\Uuid\Uuid Object (...)
   'userId' => 1

•    'seatNumbers' => Array (...)
  

  )
  '_userDefinedProperties' => Array (...)
  )

/home/dzubchik/tmp/dz-c/test/FormIntegrationTest.php:30

FAILURES!
Tests: 8, Assertions: 11, Failures: 1.

Not sure if that's possible.

First of all thank you for this useful package. We began to use it in out project but faced with a problem during object deserialization. Did you think about using this package in cases with serialization?

e.g.
class MyEvent:

{
    use Immutable;
    public int $number;
}

Calling
new MyEvent();

will throw an Exception:

Typed property MyEvent::$number must not be accessed before initialization
in vendor/matthiasnoback/convenient-immutability/src/Immutable.php (line 28) 
    $this->_defaultValues[$propertyName] = $property->getValue($this);

Can be easily fixed by changing the line to:

            if ($property->isInitialized($this)) {
                $this->_defaultValues[$propertyName] = $property->getValue($this);
            }

As it currently stands, the factory will wrap the passed in object in an Immutable wrapper. While that is efficient for simplified scenarios, it will break pretty much anywhere the type system is involved.

In addition to that, no guarantees are provided for the internal state when calling any method on the object: can probably improve that too, later on.