matter-ecs / matter-hooks Goto Github PK

Problem

As someone who uses collection service tags a lot to mark instances to have certain component, I thought it may be useful to add useCollectionService hook to handle them.

The advantage of this is that unlike useEvent, this will also handle all the instances with tag already added, meaning you won't need to run same operation twice separately for existing instances and newly tagged instances.

Proposed solution

The implementation of this hook is quite identical to useStream since it both handles addition and removal of instance, except on different event. It also has to add instances with tag already added on initialization.

Alternatives

One alternative is to have a similar implementation to what is provided in the matter docs.
https://eryn.io/matter/docs/Guides/CollectionService

Description

useMemo appears not to work.

Steps to reproduce

Steps to reproduce the behavior:

1. Prepare your Matter boilerplate.
2. Register a system that uses useMemo with a constant in the dependencies table or an empty dependencies table, a constant in the discriminator, and a print in the callback.
3. Observe the print being called each and every time without fail.

My (far from minimal) repro: umdbg.zip

Expected behavior

The callback should only run — and print — once.