matteodanelli / mmm-cryptocurrency Goto Github PK

since the fall of the Bitcoin in March there is no info of value anymore (shows nothing) only the module. Seems the www page cannot load the info. Did something change maybe an apikey needed now or chnage to https??

Ripple got renamed to XRP on Coinbase, and as a result no longer loads.

Renaming the ripple.png files to xrp.png and using "xrp" as the crypto name resolves the issue.

I hacked the code to get this effect but you may want to add a config option to enable/disable to the colorization of the change, i.e. green for positive, red for negative.

A lot of people like to keep the pure grayscale look on the mirror and that would go a long way to doing that.

Also, including a + or - depending on the change, whether color or not would be helpful.

Right now, when using displayType: detail view, there are too many redundant symbols shown.

• Percentages are shown in all change headers AND in the values themselves.
• The Euro symbol is shown in front of each currency value.

This make it hard to read from a distance.

1. How can I remove the % signs following the change values?
2. How can I remove the Euro sign prefixing the price?
3. How can I put the Euro sign in the Price header instead, like this: Price [€]?
4. How can I change the %-change header to: %Δ (24h) ?

Hi this is a pretty nice modul. But I would like to display the DOGEcoin value aswell

Please add monero XMR
Thank you once again for this awesome module

Hello,

since yesterday this module doesn't work..
A new issue ?

I want to add zcash (ZEC, 1437).
Where do you guys get/make the logos?

Merge number 41that fixed the ability to have significant digits now shows too much detail or not enough detail depending on having crypto currencies of drastically different values.
example: bitcoin currently has 7 significant figures to two decimal places, but ethereum and litecoin have 5 significant digits to two decimal places.
With the current commit, having enough digits to show the current value of bitcoin (to the penny) shows 10,000th's of a penny for litecoin.

The calendar module for example it is possible to not show the header of the module by just adding an empty header (Header: ‘’,)

This way not showing the header can be customized.

Hi

I set fontsize to medium but the display remains on xx-large

{
module: "MMM-cryptocurrency",
position: "top_right",
config: {
apikey: 'xxxxxxx-xxxxxx-xxxxxx-xxxxxx-xxxxxxxxxxxxxxxxx',
currency: ['ethereum', 'bitcoin','xrp', 'dash', 'litecoin', 'iota', 'neo','xtz'],
conversion: 'EUR',
headers: ['change24h', 'change1h', 'change7d'],
displayType: 'logoWithChanges',
showGraphs: true,
fontSize: medium,
}
}

I am getting NaN for any addition coins added.

{ module: "MMM-cryptocurrency", position: "bottom_right", config: { currency: ['bitcoin','ethereum','litecoin'], showUSD: false, //headers: ['change24h', 'change1h', 'change7d'], displayType: 'logo', showGraphs: true } }

Hey,
First, thank you so much for this module, it is an awesome add!!

I juste have one questions for you..
When I put the graph, it shows with a white background, not like in the picture, do you know why..?

Thank you very much and have a nice day!

Hey since nearly a week the graphs do not get any updates

I had a look into the implementation of those.
graph.src = 'https://s2.coinmarketcap.com/generated/sparklines/web/7d/usd/' + this.sparklineIds[apiResult[j].slug] + '.png?cachePrevention=' + Math.random()
I couldn't find any hint in the official implementation of those sparklines in the official api of coinmarketcap.
https://coinmarketcap.com/api/documentation/v1/#section/Introduction

Any tips on how to fix this?

I discovered that if i only specify one header ( headers: ['change24h'] ) it still displays the values from the apiResult.
In order to fix it we have to check how many headers are set and add the ones that are specified in the config.

So one possible way would be that we add an check for the headers before the config arrays are defined. Ideally we should now have only the headers from our config and add the values to the config arrays tableHeaderValues and tdValues

After the recent PR to change the font-size (see here) my MagicMirror setup has been showing very small fonts for each of the prices.

I've had to manually changed the line to be price.style.fontSize = '30px' in order to get the default large size back.

It could be nice to have this set to a default px value and maybe have a prop to override that if a user wants to?

Hi,
I get config error when I add it to config.js.
Think it's a MagicMirrorOS "problem", location isn't the same on MagicMirrorOS installation (~/magicmirror/mounts/modules).
Is it anything I can do?

BR!

Hi
Great Module thanks for all the hard work put into it.

Question I am getting a message saying updates available for the Module
can you tell me how to up date it please.

Hello
I would need 0x - how can I implement it pls.
thx for help

The above mentioned typo prevents the module from displaying in the right mode.
no graphs nor logos are drawn on a fresh install and since the configuration is called "displayTpe" and everywhere in the code "displayType" is tested agains it behaves as if the configuration is not set at all.

Btw.: You've made a super nice module for my mirror! Thank you so much for that.

Fix.:
just change line 9 in MMM-cryptocurrency.js to displayType: 'detail',

kind regards and all the best,
Lutz

is it possible to display ETHBTC price?

Hi,
first off, love the module. Awesome stuff!
Couple feature requests which I've currently manually changed inthe MMM-cryptocurrency.js code:

• reversed the "changes" when used with logoWithChanges to better follow the graph (which shows the most recent value on the right. The changes line now shows the order 7d-24h-1h.
• For better proportions I've also changed the fontsize for the logoWithChanges to 'small'. Maybe you can make it a css var in a future version.

Could it be possible to add the amount of money I have spent for my coins (investment), at the end of the module where I could compare it with the actual value of my coins..
eg: Total asset value: 1000€ (which is now)
original investment: 500€
profit: +100%

Hey there!

First of all thank you for the awesome extension.
Is there a possibility to reduce the shown percentages to only show the daily change?

Kind regards BiggyOC

Hey :)
I've tried to configure the module, like described in the example, but no currency shows up, while the header does.

How could i show the colors of changes colored (red, green, white) in the detail view?

thx in advance

Hello,

Thanks for creating this module!

I installed this module today with the following config:

{
        module: "MMM-cryptocurrency",
        position: "bottom bar",
        config: {
                currency: ['ethereum', 'bitcoin'],
                conversion: 'EUR',
                showUSD: false,
                headers: ['change24h', 'change1h', 'change7d'],
                displayType: 'detail',
                showGraphs: false,
                limit: '1200',
        }
},

But unfortunately it's not displaying the information. It does get the chart going, but nothing more. This is on MM 5.7.1. The only other modules I have is EmbedYouTube and mrxworktraffic. Any ideas?

Hi there matteo, first of all i really thank you for what you've done and really appreciate this module of yours man seriously. By default you set var delay to 30000 and i know you said not to set it time less than 5 minutes, which is <300, so i put it at 400,500.....all the way to 1000 and the icons are still blinking haha By any chance, is there a reason why if you would know that my icon keep blinking?

Hi,
could it be possible to add a new column (e.g. in detail mode), right after 7d forecast, in which i could paste my number of coins i have in the specific currency?
Thank you

Hello

Nice module!
I already managed to show on screen a new cc (not listed in your description).
But on the 2nd one - polkadot - nothing is showing. I wrote its name in differen ways, but noway to show.
Is it possible to have Polkadot (DOT) on screen?

BR

Hello,

Good work for this module.
I can display another crypto (OmiseGo) but there is no graph. How can I add money like airswap ?
Thanks.

Any chance of support for dogecoin?

config

		{
			module: "MMM-cryptocurrency",
			position: "bottom_right",
			config: {
				apikey: 'x',
				currency: ['bitcoin', 'ethereum'],
				conversion: 'USD',
				headers: [''],
				displayType: 'logo + showGraphs',
				showGraphs: true,
				coloredLogos: false
			}
		},

Hi,
I am going over my limit in API calls to CoinMarketCap, and it would be nice to set it in config instead of modifying the code directly.
Thanks for writing this module
Cheers,
Michel

Here's a sorted list of the 1st set of 99 coins from page 1 on coinmarketcap.com.

aelf: 2299,
aeternity: 1700,
aion: 2062,
ardor: 1320,
ark: 1586,
augur: 1104,
bancor: 1727,
'basic-attention-token': 1697,
'binance-coin': 1839,
bitcoin: 1,
'bitcoin-cash': 1831,
'bitcoin-gold': 2083,
bitshares: 463,
byteball: 1492,
'bytecoin-bcn': 372,
bytom: 1866,
cardano: 2010,
chainlink: 1975,
cindicator: 2043,
cryptonex: 2027,
dash: 131,
decred: 1168,
dent: 1886,
dentacoin: 1876,
digibyte: 109,
digixdao: 1229,
dogecoin: 74,
dragonchain: 2243,
electroneum: 2137,
emercoin: 558,
'enigma-project': 2044,
eos: 1765,
ethereum: 1027,
'ethereum-classic': 1321,
ethos: 1817,
'experience-points': 1367,
factom: 1087,
funfair: 1757,
gas: 1785,
'golem-network-tokens': 1455,
gxshares: 1750,
hshare: 1903,
icon: 2099,
iota: 1720,
kin: 1993,
komodo: 1521,
'kucoin-shares': 2087,
'kyber-network': 1982,
lisk: 1214,
litecoin: 2,
loopring: 1934,
maidsafecoin: 291,
maker: 1518,
medibloc: 2303,
monacoin: 213,
monero: 328,
neblio: 1955,
'nebulas-token': 1908,
nem: 873,
neo: 1376,
nexus: 789,
nxt: 66,
omisego: 1808,
particl: 1826,
pillar: 1834,
pivx: 1169,
populous: 1789,
'power-ledger': 2132,
qash: 2213,
qtum: 1684,
quantstamp: 2212,
raiblocks: 1567,
rchain: 2021,
reddcoin: 118,
'request-network': 2071,
ripple: 52,
salt: 1996,
siacoin: 1042,
'sirin-labs-token': 2313,
smartcash: 1828,
status: 1759,
steem: 1230,
stellar: 512,
stratis: 1343,
substratum: 1984,
syscoin: 541,
tenx: 1758,
tether: 825,
'time-new-bank': 2235,
tron: 1958,
vechain: 1904,
verge: 693,
veritaseum: 1710,
walton: 1925,
waves: 1274,
wax: 2300,
zcash: 1437,
zclassic: 1447,
zcoin: 1414,

Ready to be added to your list. You will still need to scrape the images from #26.
But at least you can see them in detail view.

Can't figure this one out. I'm using the latest version of the code and the options:

  {
  	module: "MMM-cryptocurrency",
  	position: "top_right",
  	config: {
  		currency: ['ethereum', 'ripple', 'bitcoin', 'iota'],
  		conversion: 'EUR',
  		displayLongNames: 'false',
  		displayType: 'logoWithChanges',
  		significantDigits: '5',
  		showGraphs: 'true',
  		headers: ['change24h', 'change1h', 'change7d'],
  		fontSize: 'medium'
  	}
  },

The graphs for Ethereum, Ripple and Bitcoin are showing but the graph for IOTA is not. In webpage source it shows empty instead of <img src="https://files.coinmarketcap.com/generated/sparklines/1.png?cachePrevention=0.7866182075290848">

Also the significantDigits setting of 5 are not showing anymore which did work in an older version.

Hi,
Very nice addition..
Can we add GRT (The Graph) to the list?

Thanks

Hi, could it be possible to show the global coin market cap in the header?
In Currency USD like $459.177.185.587 ?

The graph itself, on my mirror, is about 93px wide however only the right half of that is the actual graph. The left half is just empty space.

Do you know how I can remove that white space?

It currently makes the whole top right region too wide. Thx.

Binance coin Colored logo,
Can you merge this?

I cant seem to get this to work. What am I doing wrong?

{
module: "MMM-cryptocurrency",
position: "top_right",
config: {
apikey: 'XXXXX Hidden for Privacy XXXXX',
currency: [‘bitcoin’, 'ethereum', ‘ethereum-classic’, ‘xrp’, ‘cardano’],
conversion: ‘USD’,
headers: ['change24h', 'change1h', 'change7d'],
displayType: 'logoWithChanges',
showGraphs: true,
}
},

Whenever I turn the graph option on, the graph doesn't load, it only shows the ".jpg" image symbol. Has anyone else had a problem with this?

Hi!
First of all thank you for this great module. And Happy Christmas and New Year!!!
My issue is related with wrong data which is showing my graphs..
I've checked on coinmarketcap.com and coins.live sites and module's results.
There are data inconsistency about 400$/BTC and 19$/Eth.

Has anyone else encountered this issue? Everything else works well, news ticker is up to date etc. I haven't done any update/upgrade, so I am thinking that maybe something changed on coinmarketcap, but everyone would have been affected, or is it just me?

ran git pull on the dir and restarted MagicMirror the module is no longer working. i had a backup reloaded and everything worked again.

Hello
I would need Tezos - how can I implement it pls.
thx for help

Finally I have found the time to look into the issue, I was able to trace it down to the numberToLocale function. If significantDigits are set in the config, the module crashes because the array index "i" is not set. That happened after refactoring with commit 1793233, and as I can see there still is a leftover TODO at that place: "// TODO: iterate through all quotes and process properly"

To limit API calls I would like to be able to set the polling time from 5 to 10 or 15 or 20 minute intervals, would this be possible to add? Thanks, I love this module!

Hi, I wanted to try the module on my raspberry pi zero, but I have the issue that the currency and the price isn't showing. The header is displayed correctly and changes accordingly to the settings. I tried the proposed example and other settings.