mattbit / mysql-compat Goto Github PK

can you put this into one file, like this?

https://gist.github.com/rubo77/1db052edd8d723b59c79790b42635f1e

And maybe add an install instriuctions in the README would be nice

As reported in #9 (comment), the call to Connection::query is not wrapped in a try-catch:

It must instead catch the exception and return false as in the original mysql_num_rows function.

vendor folder is not available to load autoload.php

From mysql-compat/src/Connection.php:43

        $statement = $this->pdo->query($query);

        if ($statement === false) {
            throw new QueryException('Error executing the query.');
        }

For easier backwards compatability and troubleshooting, this might be more helpful if $this.getErrorInfo() were sent along with the exception.

As it is now, I don't seemingly have a way to get any error information myself, since I don't have access to the Connection from my calling code.

I ran into this because while select id, id from table works just fine, PDO apparently has an issue with the duplicate field.

I'm using this for now has a hack-fix:

throw new QueryException('Query error ' . serialize($this->getErrorInfo()));

README states that this library is requiring php >= 5.6 and PDO, but composer.json is requiring php >= 5.4 and no extension.