matt-dray / ghdump Goto Github PK

https://www.rostrum.blog/2020/08/09/ghactions-pkgs/

The protocol argument check gets evaluated even when copy_type == "download" . It shouldn't. The !protocol %in% c("https", "ssh") in the if should only evaluate if copy_type == "clone" passes. So probably change & to && (preferred) or used nested ifs.

> ghdump::ghd_copy("co-analysis", "~/Desktop/co-analysis_copies", copy_type = "download")
Error in if (copy_type == "clone" & !protocol %in% c("https", "ssh")) { : 
  argument is of length zero

Currently uses purrr::safely() in ghd_download_zips() in case a repo can't be download for whatever reason.

The failures are printed at the end of the output from ghd_download(), which is a poor user experience.

Can we get a see warnings() equivalent for reviewing the failures? Or at least cat() the failures.

In addition: Warning message:
In download.file(url = .x, destfile = paste0(dest_dir, "/", .y,  :
  cannot open URL 'https://codeload.github.com/matt-dray/2019-10-11-test-workshop/zip/master': HTTP status was '404 Not Found'

Just checks for character strings in ghd_download() right now. Need better coverage of conditions. Intermediate non-exported functions also need handling in case something weird is returned.

How to do this given how gh::gh()works? And because many of the effects are on files?

e.g. 'main'.

https://www.rostrum.blog/2020/08/09/ghactions-pkgs/

It doesn't.

Suggested fix:

system(
  paste0(
    "git clone https://github.com/", gh_user, "/", repo, ".git ", dest_dir, "/", repo
  )
)

Defaults to HTTPS iirc. Allow for SSH with a simple argument like protocol = c("https, "ssh") and ifelse some dependent paste statements.

ghd_download() is only concerned with all repos.

• Offer repo selection from this function?
• Offer personal/private only (or both) if you are recognised as accessing your own repos