matrus2 / webpack-s3-uploader Goto Github PK

Regular Expression Denial of Service
Module: mime
Published: September 27th, 2017
Reported by: Cristian-Alexandru Staicu
CVE-NONE

Details:
https://nodesecurity.io/advisories/535

Reference:
andrewrk/node-s3-client#190

Probably the best solution would be to replace node-s3-client to something similar. #

Rewrite tests and README.md to be compatible with webpack 4.

NSP check seems to not working fine, so remove it completely to not to drive users to wrong conclusions.
Possible find different app to do the same.

Is this intentional?

Current usage

basePath set to commit hash, which is intended to be the base directory in S3.
Ex: Set basePath to de40ad249, so that every assets are uploaded into that directory

Current behavior

basePath: de40ad249
Resulting basePath: de40ad249/
Resulting Key: de40ad249//assets/scripts/vendor.js

Note the additional trailing slash automatically appended by the tool, which is effectively creating an empty directory in S3.

Desired behavior

basePath: de40ad249
Resulting basePath: de40ad249
Resulting Key: de40ad249/assets/scripts/vendor.js

For the time being even if AWS credentials are wrong CI/CD job is succeed. This may break the production unintentionally.
Expected: Webpack build should fail in case of wrong credentials. If so CI/CD job should fail.

To be able to use minio with this I need to be able to set the url for "s3".

Webpack-s3-uploader throws the following exception Error: Non-file stream objects are not supported with SigV4 in AWS.S3 when using S3 locations that require SigV4 e.g. "eu-central-1"

This issue seems to be related to the node-s3-client dependency, see: andrewrk/node-s3-client#69.
Maybe consider switching to a different dependency like https://github.com/shreyawhiz/node-s3-client to solve the issue.

NEVERMIND IT WAS OUR OWN DAMN FAULT