material-components / material-components-ios-codelabs

Codelabs for Material Components for iOS (MDC-iOS)

Material Components: Shared Documentation and Policies

Material Components for Android, iOS, web and Flutter help developers execute Material Design with modular and customizable UI components. Developed by a core team of engineers and UX designers at Google, these components enable a reliable development workflow to build beautiful and functional user experiences.

This repo contains all common documentation for Material Components projects across the different platforms.

Repos

• Material Components Android
• Material Components iOS
• Material Components Web
• Material Components Flutter

Useful Links

• Contributing
• Filing an Issue
• Components Request Policy
• Code of Conduct
• Stack Overflow (external site)
• Material.io (external site)
• Material Design Guidelines (external site)
• Discord Chat Rooms (external site)

material-components-ios-codelabs's Issues

[MDC103] Swift Step4 wrong theme

in "Change the typeface of the login screen" section
codelab page

wrong

MDCButtonTypographyThemer.applyTypographyScheme(typographyScheme,
to: cancelButton)

fix

MDCTextButtonColorThemer.applySemanticColorScheme(colorScheme, to: self.cancelButton)

when i apply wrong code,cancel button theme is the same as next button.

Go link doesn't work

Linking with a go/ link doesn't work. Update the link in point 3 on https://codelabs.developers.google.com/codelabs/mdc-101-swift/#2

Password validation error doesn't disappear

The validation for the password field needs an else block to clear the error if it was in the error state already.
if (...) { passwordTextFieldController.setErrorText("Password is too short", errorAccessibilityValue: nil) } else { passwordTextFieldController.setErrorText(nil, errorAccessibilityValue: nil) }

Requires XCode 9.3

This project requires XCode 9.3 because the iOS deployment target is set to 11.3, but the Codelabs computers only have XCode 9.2 installed. So you should drop the target to 9.2

CodeLab has wrong git branch listed

https://codelabs.developers.google.com/codelabs/mdc-103-flutter/index.html
The MDC-103 Flutter codelab states that the branch to us is this.

git clone https://github.com/material-components/material-components-flutter-codelabs.git
cd material-components-flutter-codelabs
git checkout 102-starter_and_101-complete

The correct branch is 103-starter_and_102-complete

Please add example usage on using Shadow Elevation and Shadow Layer

https://codelabs.developers.google.com/codelabs/mdc-103-swift/ says it covers shadow elevation but doesn't have those details anywhere in text.

Please make example of using MDCTabBar stays on top and manages each view controllers

Signing error when running Shrine MDC-01 Swift Starter

Signing for "MaterialComponents-MaterialIcons_ic_chevron_right" requires a development team. Select a development team in the Signing & Capabilities editor.

Adding my own apple ID and Personal Team did not work.
How to proceed?

MDCChipField manual addChip don't have delete button

When I use the - (void)addChip:(MDCChipView *)chip function in MDCChipField and "showChipsDeleteButton" is true, I was expecting it to put the delete button on my new chip.

[103 ObjC] TypographyScheme comment references ColorScheme

The TypographyScheme initialization comment on Line 78 of ApplicationScheme.m refers to an MDCSemanticColorScheme object.

 // Instantiate a MDCSemanticColorScheme object and modify it to our chosen colors
    _typographyScheme =
        [[MDCTypographyScheme alloc] initWithDefaults:MDCTypographySchemeDefaultsMaterial201804];

The bug seems to originate in the instructions, which have the wrong wording as well.

https://codelabs.developers.google.com/codelabs/mdc-103-objc/index.html?index=..%2F..index#3

MDC-104 iOS, Step 5: Minor typo

Minor typo: the HomeViewController.m is Obj-C style, use HomeViewController.swift instead.

site elements are overflowing aout of the screen and cant be adjusted

textField border color difference

hi, I have a question as below:
(please do not mind the larger font size, just for good look.

captured picture in Login view, MDC-103 tutorial,

and my finished below, please have a notice on textfield border color,

---

what did I miss something about textfield border setting?

MDC-103 iOS, Step 3: Syntax error

In Apply the colors to the home screen

wrong
MDCAppBarColorThemer.applySemanticColorScheme(ApplicationScheme.shared.colorScheme, to:self.appBar)

fixed
MDCAppBarColorThemer.applyColorScheme(ApplicationScheme.shared.colorScheme, to: self.appBarViewController)

Importing MD components in a personal project

I am unable to import MaterialComponents.

Typo in MDC-103 step 8

In the MDC-103 step 8 with brightness: Brightness.light you changed the status bar from black to pink, but it's written:

Now the products scroll horizontally in a woven-inspired pattern. Also, the status bar (time and network at the top) is now black. That's because we changed the AppBar's brightness to light, brightness: Brightness.light

It should be:

Now the products scroll horizontally in a woven-inspired pattern. Also, the status bar (time and network at the top) is now pink. That's because we changed the AppBar's brightness to light, brightness: Brightness.light

syntax error

This line on MDC-104 iOS in the "Add filtering" section is not correct
Catalog.categoryFilter = filter

The line should be
[Catalog productCatalog].categoryFilter = filter;

Thanks,
Yuval

keyboard appears and pushes the bottom sheet to its top

MDCBottomSheetController with a contentViewController that contains an UITextField. When the textfield becomes first responder, the keyboard appears and pushes the bottom sheet to its top.