material-components / material-components-flutter-motion-codelab

Codelab for Material motion for Flutter

Material Components: Shared Documentation and Policies

Material Components for Android, iOS, web and Flutter help developers execute Material Design with modular and customizable UI components. Developed by a core team of engineers and UX designers at Google, these components enable a reliable development workflow to build beautiful and functional user experiences.

This repo contains all common documentation for Material Components projects across the different platforms.

Repos

• Material Components Android
• Material Components iOS
• Material Components Web
• Material Components Flutter

Useful Links

• Contributing
• Filing an Issue
• Components Request Policy
• Code of Conduct
• Stack Overflow (external site)
• Material.io (external site)
• Material Design Guidelines (external site)
• Discord Chat Rooms (external site)

material-components-flutter-motion-codelab's Issues

Git command retrieves the `develop` branch

On page three of the codelab, there is an option to download the starter app using this git command git clone https://github.com/material-components/material-components-flutter-motion-codelab.git. However, the resulting repo will be on the default develop branch, which has nothing but a readme file. I think this command needs to specify the starter branch instead.

.gif sizes

Due to my awful internet connection, I noticed some of the gifs are quite large. (10-15mb each). This leads to a poor experience as the images freezes.

Possible options are:

1. Smaller gifs, this may lower quality
2. Embed webm or mp4 directly, this would allow smooth animations (preferable)

'TransitionBuilderPage' shows error

TransitionBuilderPage shows error in starter branch in router.dart and mail_view_router.dart.

What to do?

Prefer to use TransitionBuilderPage or equivalent over custom solution

#30 and #31 move away from using TransitionBuilderPage since it has not landed in stable and was recently removed from master flutter/flutter#66694 . Revisit the implementation in these PR's once TransitionBuilderPage or the equivalent has been pushed to stable.

Exception occurs in router.dart

I just did
git clone https://github.com/material-components/material-components-flutter-motion-codelab.git
and flutter pub get then run this app and this exeption occured (lib/router.dart line:34).
_CastError (Null check operator used on a null value)

flutter doctor output

[√] Flutter (Channel stable, 2.5.0, on Microsoft Windows [Version 10.0.19042.1165], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 4.0)
[√] VS Code (version 1.60.0)
[√] Connected device (3 available)```

Typo in the codelabs at step 10

FadeThroughTransitionSwitcher(

should be

_FadeThroughTransitionSwitcher(

https://codelabs.developers.google.com/codelabs/material-motion-flutter#9

Viewing images in README.md

To view the image files in README.md in the table row, be sure to use Markdown like this:

| ||

The original HTML tag below won't display the images as intended:

| | |

I'm not sure if MD will accept the image size constraints above, but my MD displays fine in IntelliJ

Back swipe does not work in iOS.

Github repo link is pointing to the android repository

At step 3, Option 1, the link is directing to https://github.com/material-components/material-components-android-motion-codelab while it should go to https://github.com/material-components/material-components-flutter-motion-codelab.

Project in a broken state

Flutter 1.23.0-8.0.pre.137 • channel master • https://github.com/flutter/flutter.git
Framework • revision ece2f98eb0
Engine • revision a8d7d97bef
Tools • Dart 2.11.0 (build 2.11.0-185.0.dev)

Lots of errors in the project in the starter branch

Several instance where these errors occurs:
Undefined name 'standardEasing'
Undefined name 'Router'.
The method 'ChildBackButtonDispatcher' isn't defined for the type '_MailRouter'.
The name 'RootBackButtonDispatcher' isn't a type, so it can't be used in an 'as' expression.
The method 'Router' isn't defined for the type '_MailRouter'.
Mixin can only be applied to class.
Classes can only mix in mixins and classes.
Classes can only extend other classes.
Undefined class 'RouteInformation'.
The method 'RouteInformation' isn't defined for the type 'ReplyRouteInformationParser'.