matarillo / languageserverprotocol Goto Github PK

I am creating function signature help for a language that I'm enabling in VS Code. I am having an issue where only one of the function parameters displays in VS Code. Is this known behavior or am I doing something wrong?

SignatureHelp test = new SignatureHelp();

var sig = new SignatureInformation();
sig.label = "shuffle";
sig.documentation = "shuffle(float v, int i)";

sig.parameters = new []
{
	new ParameterInformation
	{
		label = "float",
		documentation = "Float register."
	},
	new ParameterInformation
	{
		label = "int",
		documentation = "Bits to shuffle."
	}
};

test.signatures = new SignatureInformation[1];
test.signatures[0] = sig;

return Result<SignatureHelp, ResponseError>.Success(test);

Cheers,

Pete

https://microsoft.github.io/language-server-protocol/specification#version_3_1_0

I'm trying to support LSP using your implementation and some PoC code working (https://twitter.com/atsushi_eno/status/1021226599172038656).

Though it is not really ready to let others try, because the LSP process somehow does not terminate. Even worse, after vscode itself quits it spins like it were using SpinWait. It seems to happen to your LSP example project too. It does quit when I quit vscode for the language client project though (i.e. closing "extension host" causes spinwait. Closing vscode for LS client folder stops it).

Is there any way to explicitly shut down the LSP process by any LS requests like Exit()? It does not seem to work either.

Expected: where TRequest : NotificationMessageBase
Current: where TRequest : RequestMessageBase

Thank you for the nice lightweight implementation :-)

I'd suggest making ConnectionHandlerProvider public or otherwise add a way to invoke AddHandlers manually. Currently one has to derive from ServiceConnection and override all methods in the same class. I would be more convenient if one could add handlers implemented in different classes.

This part:

protected ServiceConnection(Stream input, Stream output)
...
       var provider = new ConnectionHandlerProvider();
       provider.AddHandlers(Handlers, this.GetType());
}

As @MikhailArkhipov reports in #1 (comment)

There is also a problem with nuget - it depends on Matarillo.IO but does not install the dependency. And dependency is 'ProtocolReader' - but installs Matarillo.IO which is confusing.