massive-oss / mlib Goto Github PK

haxelib run mlib incrementVersion doesn't work

i am getting Uncaught exception - std@sys_stat at
https://github.com/massiveinteractive/MassiveLib/blob/master/src/massive/sys/util/ZipUtil.hx#L97
while processing directories ending with ""

Mlib 2.0.2 and Haxe 3 release.
Windows 8 x64

MLib 2.0.0 is incompatible with Haxelib 1.04. Haxelib's command test is renamed to local

@dpeek please update library on haxelib

With the new haxelib version project file are now haxelib.json.

Unfortunately, mlib still look for haxelib.xml

Got the following error compiling to cpp (windows) target:

C:\HaxeToolkit\haxe\lib/mlib/2,0,2/massive/sys/io/FileSys.hx:47: characters 18-2
2 : On static platforms, null can't be used as basic type Bool
C:\HaxeToolkit\haxe\lib/mlib/2,0,2/massive/sys/io/FileSys.hx:56: characters 14-1
8 : On static platforms, null can't be used as basic type Bool
C:\HaxeToolkit\haxe\lib/mlib/2,0,2/massive/sys/io/FileSys.hx:65: characters 16-2
0 : On static platforms, null can't be used as basic type Bool

solution was to remove the conditions if (isLinux == null) , if (isWindows == null), if (isMax == null) at those lines, they weren't doing much btw.

Is this repo still maintained? Would be glad if so, thanks.

It might be a bit out of the norm, but most tools / apps I've encountered (even cmd.exe) support forward slash style absolute paths on Windows.

If this is an explicit choice a better error message than "Path isn't absolute and no reference file provided" would be helpful at least.

I've only had a cursory look at the code, so I don't know what would be the best proper way to add this, but the simplest would be to adjust the slash direction according to expectations. I suppose modifying paths is not the most expected / preferred outcome, so perhaps adding support for both directions might be better, albeit probably trickier and would double a lot of code.

It can be useful to have the description text in the haxelib.xml file wrapped in in CDATA tag (to include links on haxelib page for example).

Unfortunately, using mlib to increment the version removes the CDATA tags.

Compare http://lib.haxe.org/p/munit/ with http://lib.haxe.org/p/mlib/ -- as a newcomer I was pretty confused. I think this would just take a haxelib.json resubmit. I would submit a PR but I see haxelib.json is part of .gitignore, so it's not part of the repo to take and modify.