Coder Social home page Coder Social logo

martynaskre / magic-home-desktop Goto Github PK

View Code? Open in Web Editor NEW
93.0 7.0 29.0 3.03 MB

Desktop app for Windows and MacOS to control Magic Home LEDs.

Home Page: https://magic-control.skrebe.me/

License: MIT License

JavaScript 4.66% HTML 0.66% Vue 47.37% Shell 0.39% TypeScript 46.93%
magic-home leds led led-control magic-home-control magic-home-desktop

magic-home-desktop's People

Contributors

martynaskre avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

magic-home-desktop's Issues

Max brightness not 100%

I have a magic hue bulb, if I control it using your app the max brightness is whatever the brightness was at the moment of discovery. So if its on like 10% You get to control it from 0 to 10% with the slider instead of 0% to 100%

Support for us unlucky GRB light owners?

What it says on the tin. Basically my lights are GRB, not RGB,so the green and red signals are swapped on almost every controller I find. If I were more skilled I 'd modify tho code myself, but oh well. All I can do is politely ask you to consider that small addition <3.

Please add ambilight

the function of pickup a colour of my desktop every 0.5s for example and send to the light strip. thanks for the app, this is the only one that worked for me

[ENHANCEMENT] STREAM DECK

I would love for there to be a version of this that i can use on my stream deck while in games, as when i use my Alexa i can say mayday mayday mayday and the lights turn red, it would be amazing if we could have preset keys on our stream decks to do it for us.
Describe alternatives you've considered
i have considered setting up a raspberry pi to connect instead of the box and just hosting a web controller from it. and then using an app on my pc to control it, ive thought about using a usb sniffer to make my own control panel from my pc, but then i found this.

do i have your permission to use your code and make a twitch bot that can control my lights from my pc depending on what the users ether type in chat or if they donate, or if they use channel points to make it strobe or something like that.

[ENHANCEMENT]

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Ability to make leds adapt to pc sound (like voice on mobile app)

Describe alternatives you've considered
None

Additional context
Nope

Do you need to be on the same network as the led strip to run this

My Network issue

i have a mesh router setup as my main network (tp link deco) but most cheap led controllers don't like mesh networks and don't connect to it. so i bought a cheap router from amazon and use it for these cheap led strips and other iot devices, but all my other devices, such as phone and laptops are on my main network

The problem

My laptop does not 'discover' my led strip

Desktop Sync?

Thanks for this awesome app!

There are some projects for LIFX and HUE that sync colors of the lights with the desktop or a specific desktop area.
Do you think you could add such a feature?

Color Wheel (With White)

Thank you for creating this app. It has helped me alot when I want to control my lights without getting on my phone.

The only issue I have with this is the color selector. It looks nice, but is very confusing to use and there is no way to chose a white value. Would it be possible to add the default macOS color wheel in the app? Thank you again.

[BUG] Program's window is not movable

Describe the bug
Program's window is not movable, it's stuck at the bottom left corner of the screen, I'm not sure if it was meant to be this way or if it's a bug, but it's extremely inconvenient.

how to open?

I have windows 10 but i don't know how to open the app.
Pls help me.
Thanks

Unable to set presets with RGB values

Hi!

Love that you did this. Will save me pulling my phone out to change the lighting!

On the 'official' Magic Home app, you can set your presets using RGB values, instead of the colour wheel. Could we get this added?

It's especially important to me, as I have a janky setup with warm white LEDs in the blue channel, so the colour wheel makes little sense. I have the RGB (actually RGW I suppose) values I use saved though.

Thanks for your effort!

(I can't figure out how to tag this an enhancement by the way.)

[ENHANCEMENT] Add custom functions to the app

Is your feature request related to a problem? Please describe.
In the current state of the app, I can only set static colors.

Describe the solution you'd like
Adding a section for applying different patterns, just like the original Magic Home Pro app.

Describe alternatives you've considered
Currently I'm using the app separately to apply those effects.

Additional context
By using setPattern function from magic-home, this would be easily done.

[ENHANCEMENT]

It would very good if you were able to type in the raw hex/rgb values to get the exact colour that you
are trying to achieve. So instead of dragging on the colour wheel to try and get straight green, I could type in 00FF00 and it would go to that colour.

[BUG] Dependencies are outdated.

When trying to run/build the project myself I encountered a lot of errors with outdated dependencies that needed older versions of node etc. Especially with node-saas (which is apparently not even in use).

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repo
  2. Install dependencies with yarn
  3. Run ``yarn run electron:serveornpm run electron:serve```

Expected behavior
I wanted to be able to locally run and build the projects as there is not linux release.

Desktop (please complete the following information):

  • OS: Linux x86

Additional context
I tried fixing this myself. Here's what I did (to no avail):

  • Tried to install a run did not work because of old node-saas error not running linux systems
  • Upgraded node-saas to be able to run on Linux
  • node-saas gives error similar to Node Sass version 5.0.0 is incompatible with ^4.0.0
  • try to use node 7 does not work

I realize I probably did not approach the issue the right way to solve it but I don't much experience with outdated dependencies.

It would be really helpful if you could update them. Thanks.

Window doesn't refresh

I've tried upgrading from v0.2 to v1.0 and I had no problems with v0.2 but after upgrading to v1.0 I get this bug where the main app window doesn't refresh when I press buttons.
Surprisingly, the program still works, if I press "turn LEDs off" the LEDs do turn off, and I can access settings and go back, but I can't see them.

Check the gif below to understand what I mean:
magic

Here's my OS info, let me know if you need any more info:
image

Lightbulb normal "colors" not present on app.

So with the rgb bulbs if you pick solid colors it is very very dim but in the phone app you have the warm & cool options which is normal light bulb in warm/cool variant. If that gets fixed or added it would be fantastic. Ty

[BUG]

Describe the bug
The window opens half off-screen. Only the word "Control" is visible in the title bar. The window cannot be dragged on-screen by dragging the title bar. No contextual menu is available when shift-right-clicking the title bar.

To Reproduce
Steps to reproduce the behavior:

  1. Click Magic Control on the task bar.

Expected behavior

  1. App window opens on screen
  2. App can be dragged around by clicking on the title bar

Screenshots
MagicControlOffScreen

Desktop (please complete the following information):

  • OS: Windows 11

Additional context
It recently started happening. No idea why. i have not changed the screen resolution at any time.

question about magic home

so nice app, im very corious about how this work i mean in the code way

  • how do you that X device on the network is a magic home device?
  • once you got the basic ip, name and mac, how do u turn it on/off/colours/bright?

thanks and sorry i know that it must be in the code but cant find it

Screen Color Sync

Describe the solution you'd like
Can it find prominent color on the screen and make the led color match that?

Multiple lights with one keybind?

hi i was wondering if u could make it so the same keybind can control multiple lights, as ive tried but it only seems to turn on one when the same keybind is connected to all the lights

Window key not workinga after install this app

Hello
This app automates led strip pretty well. The only problem I have is that my win key and the popup menu key stopped working after installing this app.
How can I have these keys working again?
Thanks for the great job.

[ENHANCEMENT]

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
it would be nice if it had a api that you could interact with, so someone could make there own program that does something with there lights

Describe alternatives you've considered
add plugin support

Additional context
nop

No idea how to run this?

No instructions in read me?

What do i need to use this? No windows.exe or running instructions or specifications on what is needed to run...

configure a macro for a preset

Add the possibility of configuring a keybind per preset pre-record

Ex: ctrl + F1 for the white, ctrl + F2 for the red etc ...

(I'm French, sorry if my English is bad)

Does Nothing. Discover Devices Button Does Nothing [BUG]

Describe the bug
A clear and concise description of what the bug is.
The bug is the 'magic' it does after clicking Dicover Devices doesnt even pretend to do anything. And you have no info or possible issues and fixes. ehatb thue f is wrong with you? pos
To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows]

Additional context
Add any other context about the problem here.

Pull Request: Add Hotkey for Preset Color / Color Preview from Home Screen / Global Dark Mode Setting

Hello,

I stumbled on your repo earlier today, and I think your work is great! I have a bunch of magic home controlled LEDs, and I've found your code to be exactly what i've been needing. I'd love to contribute.

Here are some ideas, I have and how i'd go about implementing them.
Please let me know if you have more information that might help.

  1. Hotkey Colors
  • Add a button in the color picking menu picker.vue, to save the current color and brightness. (Possibly up to 5 'presets')
  • Add a button to the device.vue, to save an additional hotkey. OR have presets work with '(Hotkey) + (1-5)'.
    Plan:
    Store preset settings into 'store' vue variable. ( store.state.Leds.leds[LEDkey].presets["1-5"] )
    Use hotkey.vue to record additional hotkeys for presets.
  1. Color Preview in Home menu, to the left of the devices name.
  • Add an 'icon' that shows the current RGB setting into device.vue
    Plan:
    in device.vue add a css box with the RGB value for each device.
  1. Dark Mode Setting
  • Add an addition settings button to change background-color for each page to black.
    Plan:
    I have this implemented with css styles on each page, set to dark mode.
    This css will be changed from a button in Footer.vue, calling a function to modify the css style of each page.

Looking forward to hearing from you!

[ENHANCEMENT] - "Ambilight" Option

Describe the solution you'd like

It would be great over the current working base - incredible, thank you - to have the option of "Ambilight", under my perception would be something like taking the overall -or similar- color shown in the main screen and setting it on the leds. It would be needed to keep refreshing while the option is turned on.

Describe alternatives you've considered
Other alternative, but not as good as the stated above would be to have sort of "eye-dropper" color selector that can take any color on the screen.

Additional context

Check it out - https://github.com/dewgenenny/ScreenSync
https://youtu.be/izCWz9-xkw4

[ENHANCEMENT] LED visualizer

I suggest to make some visualizer that the leds change color to the beat of the music or bass.
It would be good if it listened to the process we choose, e.g. spotify.exe

[BUG]

Describe the bug
If I open Magic Control I am unable to see my devices and the aligning of the window isn't correct either.
To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Taskbar'
  2. Click on 'Magic Control'
  3. See error

Expected behavior
I expected to see my lights and the application to be opened correctly.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 Home 64-Bit
  • Version:10.0.19044 Build 19044
  • Release 21H2

Additional context
I can't see any of my devices and the application doesn't work due to the way it application opens.

Enhancement feature: Turn off Led lights when shutting down

Hi Martynas.
First of all, I'm amazed by your app. It works great. Thank you for making it available.
It would be awesome if you could improve your app with a checkbox option (just like your "Open on Startup") to turn off the Led lights when shutting down the computer and turn them on automatically when PC powers on.

Thank you once again.

[ENHANCEMENT] Color pattern for pixel LED stripes

First of all, I really love the app and really appreciate you working on this when there is no other solution at reach and coming up with a really clean design that does exactly what was intended to do. So, for that thanks a lot!

Is your feature request related to a problem? Please describe.
The pre-configured LED effects are not available te select, only solid colors

Describe the solution you'd like
It would be great to have the ability to choose at least one of the modes from the app.

Describe alternatives you've considered
Maybe adding mode customization? That way maybe instead of pulling all the modes you need to set your own but at least that's something.

Additional context
I'm using a Pixel RGB led stripe with a magic home controller

Rename devices

Is it possible to rename my devices? Possible enhancement?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.