martinsstewart / elm-review-bot

A bot that uses elm-review to find common mistakes in packages.

elm-review-bot

A bot that uses elm-review to find common mistakes in Elm packages.

Currently the bot only checks if there are unused dependencies but some future checks might be:

• Check that the Elm version range in the elm.json file is valid
• Check that packages don't depend on packages that no longer exist
• Check that all the types used by exposed functions are also exposed
• Detect Debug.* functions (apparently there's some bug that lets you include Debug.log in published packages)

This bot is written 100% written using Elm and is hosted with Lamdera.

elm-review-bot's Issues

Only add Elm modules that are actually used by a package

Currently all Elm modules in a packages src/ and tests/ folder are added. Sometimes modules in those folders aren't actually used by the package though and this can cause problems if there's name collisions or if the extra modules don't parse.

Improve performance and reduce ram usage

Currently it takes forever to check all the packages ~700 packages per hour and it eats so much ram that the Lamdera app dies. This might be due to agu-z/elm-zip being unoptimised but it could be something else as well.

false positive `Unused.Dependencies`

elm-review-bot created a new PR in elm-bits.
When I run the suggested

npx elm-review --template jfmengels/elm-review-unused/example --rules NoUnused.Dependencies

or try running elm-review with the newest elm-review-unused dependency installed, no errors are found.

elm-review-bot however, suggests

-   "lue-bird/elm-typed-value": "5.0.0 <= v < 6.0.0",
    "lue-bird/elm-typesafe-array": "18.0.0 <= v < 19.0.0"
},
"test-dependencies": {
+   "lue-bird/elm-typed-value": "5.0.0 <= v < 6.0.0"
}

This is probably (?) an issue with the used elm-review-unused version (bot uses 1.1.9, latest is 1.1.16).

Forked projects can get confusing PRs from the review bot.

https://github.com/the-sett/elm-localstorage/pull/1/files

The above was originally forked from billstclair/elm-localstorage. You can see that the PR reverts its elm.json to that name.

Seems like the review bot gets confused because it needs to fork projects to create PRs, and the author name does not get included in the fork. No idea how you would solve this...