martinrunge / muroa Goto Github PK

It is for example possible to start muroad on a target without avahi-daemon running there. It will start up normally, but msessiond cannot find it.

Muroa uses system time to keep client and server in sync. If system time is not in sync, the following issues arise:

• two clients with system time out of sync will not play audio syncronously
• if system time of client is before server, starting and resetting a stream is not smooth at all, as the server sets a presentation time stamp and the client with early system time interprets that PTS in its own time context. Result is: clients starts to playback too early with playback buffer too empty and gets from one buffer under run to the next.

in CStreamServer::sendToAllClients, there is a race condition that can cause msessiond to crash when a render client is removed by the avahi thread while playing.
A lock is needed to protect m_connection_list against access by multiple threads.

When a client shuts down the TCP connection, the server can detect that and everything is fine. More complicated cases enclose:

• the client crashes
• the client is suspended (to RAM/to disk)
• network cable pulled / network went down

in these cases, the server keeps the TCP connection up and waits for the client coming backand all data sent in between is queued and passed to the client in one rush when client is reached again. This "old" data may not confuse the client as it is only interested in the latest state or in a summary (aka diff) of all changes made since it had a connection last time.

TODO:
Server:

• detect quickly, if a client cannot be reached any more and close that connection. leave "how quickly" as a tuning parameter.

Client:

• detect suspend and resume.
• on resume, first test if the old connection is still usable
• If not, cleanly open a new connection to the server after wakeup and ask for the latest changes as diff
• If server's messages are inconsistant to the client, ask for the diff between last "known good" state and current state to get up to date again.

when loading and storing playlists to and from disk, make sure that the new ID mechanism is staying intact. At least the static member m_next_free_id has to be restored. Maybe it is also neccessary to save the state of the next_free_id variable instead of having it static.

Enable the client GUI not before the client joined a session. Enabling the GUI as soon as the TCP connection is up is too early.
Selecting and joining a session is mandatory for a new TCP connection.