martinmajor / async-request Goto Github PK

Hey @MartinMajor
I have just noticed that some syntax like method return type is only available in PHP7. How are you going to address for people who are using an older version of php?

Hey @MartinMajor,
Would you mind publishing this project on https://packagist.org so that I can add it as a dependency in my project I try it out?
Thanks.

that's ok as long as it always returns CURLM_OK, which it is supposed to do, in lack of errors,

but per https://curl.haxx.se/libcurl/c/libcurl-errors.html it can also return other values, for example:

CURLM_OK (0)

Things are fine.

CURLM_OUT_OF_MEMORY (3)

You are doomed.

CURLM_UNKNOWN_OPTION (6)

curl_multi_setopt() with unsupported option (Added in 7.15.4)

CURLM_INTERNAL_ERROR (4)

This can only be returned if libcurl bugs. Please report it to us!

i suggest that instead of our current

while (curl_multi_exec($this->handle, $runningCount) === CURLM_CALL_MULTI_PERFORM);

approach, we do something like

do{
    $err = curl_multi_exec($this->handle, $runningCount);
} while($err === CURLM_CALL_MULTI_PERFORM);
if($err !== CURLM_OK){
    throw new \RuntimeException(...)
}

also error info can be obtained by doing something like:

                $errinfo = [
                    "multi_exec_return" => $err,
                    "curl_multi_errno" => curl_multi_errno($mh),
                    "curl_multi_strerror" => curl_multi_strerror($err)
                ];

Could you please give a hint how can I add pause before making each request?
I don't want all of my requests in queue start simultaneously, but rather one after another, for example every 1 second.
Thank you!