Coder Social home page Coder Social logo

svgexport's People

Contributors

martingraham avatar svrnm avatar xinczhang avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

svgexport's Issues

Export fails in SVG w/ Animation

<repost from the Chrome extensions site since I'm not sure which one you monitor>

In svgexp.js, in parentChain around line 121.

elemData.class.split fails in some cases.

In my case, it was because elemData.class is of type SVGAnimatedString instead of type object.

I was able to fix locally by wrapping lines 121 - 132 with an if clause that checks the type of elemData.class like so:

function parentChain (elem, styles) {
// Capture id / classes of svg's parent chain.
var ownerDoc = elem.ownerDocument || document;
var elemArr = [];
while (elem.parentNode !== ownerDoc && elem.parentNode !== null) {
elem = elem.parentNode;
elemArr.push ({id: elem.id, class: elem.className});
}

// see if id or element class are referenced in any styles collected below the svg node
// if not, null the id / class as they're not going to be relevant
elemArr.forEach (function (elemData) {
    var presences = {id: false, class: false};
if(typeof(elemData.class) == "string") {
        var classes = elemData.class.split(" ").filter(function(a) { return a.length > 0; });   // v1.13: may be multiple classes in a containing class attribute
        styles.forEach (function (style) {
            for (var c = 0; c < classes.length; c++) {
                if (style.indexOf ("."+classes[c]) >= 0) {
                    presences.class = true;
                    break;  // no need to keep looking through rest of classtypes if one is needed
                }
            }
            if (elemData.id && style.indexOf ("#"+elemData.id) >= 0) {
                presences.id = true;
    	    }
        });
};
    Object.keys(presences).forEach (function (presence) {
        if (!presences[presence]) { elemData[presence] = undefined; }
    });
});

return elemArr;

}

This fix is probably sub-optimal because it would miss styles on the elements causing the error. I figure you will know a better way.

With thanks,
Rob

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.