marovira / atlas Goto Github PK

Primarily talking about https://github.com/marovira/atlas/blob/master/source/atlas/utils/Mesh.cpp#L228. Here the if statement says if we have textures, but no attrib index for them, than we return. However, if we have no textures and we don't specify an index for textures (we want to render without textures), than we don't hit that code within the if statement and crash on an index out of error. Same applies for the normal check above

The compiler (at least in the lab) does not like the call to std::abs() in the areEqual method (line 37) in core/Float.hpp. It would like a simple 'abs()' (no std::)

Issues with Clang and c++11 come from line 58 in CMakeLists.txt:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")

should be

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libstdc++")

Atlas fails to compile with texture support on the lab machines.

Hey @marovira,

Just wanted to let you know that if you cloned the marovira/atlas repo in a folder name with spaces and you try to run the make command then it will get this build error,

[ 99%] Generating HTML documentation
error: tag HTML_HEADER: header file `/home/poanchen/Downloads/folderwithspaces/atlas/external/glfw/docs/header.html' does not exist
external/glfw/docs/CMakeFiles/docs.dir/build.make:57: recipe for target 'external/glfw/docs/CMakeFiles/docs' failed
make[2]: *** [external/glfw/docs/CMakeFiles/docs] Error 1
CMakeFiles/Makefile2:1248: recipe for target 'external/glfw/docs/CMakeFiles/docs.dir/all' failed
make[1]: *** [external/glfw/docs/CMakeFiles/docs.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

Things that I did:
I looked into the problem and it WAS NOT a bug in your repo. It was an edge case that was not covered in glfw/glfw. As the Doxyfile generation does not handle paths with spaces in them. As a result, I ended up creating an issue with them and they have resolved the issue quickly and it is now fixed/closed in their repo. The issue link is glfw/glfw#1081. I am not sure what the action should you take but just wanted to let you know this. (as long as your folder name does not contains spaces then the make process will pass, so the workaround is make sure the folder name does not contains any spaces)

Thank you!

Cheers,
Baron

Create some documentation for the Tools library for Atlas.

Links to code definitions within the Wiki (under classes) lead to dead pages. I'm sure that most code references do this at the moment. Pretty minor issue.

In the case that comments are written above a version declaration for a GLSL shader, the parser does not work as expected.

For example,
// Author: Noah Serr
#version 450 core
...
will not parse correctly.

Add the support for multiple scenes in the application class.

Should be if (APPLE OR WIN32). Capitalization of OR seems to fix a build issue on Mac OS