Coder Social home page Coder Social logo

marmelab / aor-rich-text-input Goto Github PK

View Code? Open in Web Editor NEW
23.0 15.0 25.0 10 KB

<RichTextInput> component for admin-on-rest, useful for editing HTML code in admin GUIs

License: MIT License

Makefile 9.02% CSS 55.86% JavaScript 35.12%
admin-on-rest react

aor-rich-text-input's Issues

style="color: rgb(0, 0, 0)"

The editor seems to apply style="color: rgb(0, 0, 0)" to tags (strong, em, etc) on text created with the editor, which then overrides the styles that would be applied to the text on our front-end. Why is this being applied? How can we make it not do this? Thanks.

The package is crashed when importing at the existed admin on rest project code.

I installed this package additionally at the existing aor project.
But it was crashing when importing at the code.
Following is dependencies and log from terminal.

"dependencies": {
    "admin-on-rest": "^1.4.0",
    "aor-loopback": "^1.3.2",
    "aor-rich-text-input": "^1.0.2",
ERROR in ./node_modules/aor-rich-text-input/lib/RichTextInput.css
Module parse failed: Unexpected character '@' (1:0)
You may need an appropriate loader to handle this file type.
| @import "~quill/dist/quill.snow.css";
| 
| .aor-rich-text-input .ql-editor {
 @ ./node_modules/aor-rich-text-input/lib/index.js 33:0-30
 @ ./client/containers/crud/talent.js
 @ ./client/containers/app.js
 @ ./client/index.js
 @ multi webpack-hot-middleware/client ./client/index

Explore code splitting options

Quill.js, the main dependency of aor-rich-text-input, is a large addition to the bundle size of any SPA. Here, on admin-on-rest-demo, it's taking 14% of the bundle size.

image

We should provide a lazy loading alternative for people using a bundler compatible with code splitting.

Loosen quill dependency lock

Any reason for locking on Quill minor 1.1?
We're using zenoamaro/react-quill and as a result we end up with multiple versions of quill in webpack bundle. Could we change aor-rich-text-input dependency on quill to either: ~1.1 or ^1.1.9?

Quill adds padding without matchvisual option

I was trying out AOR and noticed it was adding extra padding before a list.

With some searching, I discovered this is a known feature, but can be disabled in Quill 1.3+. This component currently only supports Quill ~1.1.9, so I'm not sure if there is something stopping aor-rich-text-input going to version Quill 1.3?

Quill issue about padding here:
quilljs/quill#1483

Quill matchvisual option documentation:
https://quilljs.com/docs/modules/clipboard/#matchvisual

How to set default direction on RTL in RichTextInput

I'm using the Admin-on-rest framework. I read AOS and Quill documents and don't find any solution.
How to set default direction on RTL in RichTextInput?
I want to it always be right-to-left.

    export const BookCreate = (props) => (
        <Create {...props} title="ایجاد کتاب جدید">
            <SimpleForm>
                <TextInput label="عنوان کتاب" source="title" />
                <RichTextInput label="توضیحات" source="description" formats={[{direction:'rtl'}]} toolbar={[ 
                    ['bold', 'italic', 'underline', 'link'],
                    [{ 'direction': 'rtl' }],
                    [{ 'align': [] }],
                    ['clean'],
                    [{ 'list': 'ordered'}, { 'list': 'bullet' }],
                ]} />
            </SimpleForm>
        </Create>
    );

Empty content on first load

Coming from the listing, the field is empty. After hitting refresh button, the field is filled.

If I log the value received in componentDidMount, I see it's empty the first time and not the second one.

demo

Editor is not rendered

Hi,

I encountered a problem with this Component.

I use the RichTextInput with HydraAdmin from "Les Tilleuls".

The code below throw an error :

 <RichTextInput {...props} source="description" addLabel={true} />
uncaught at handleFetch TypeError: Cannot read property 'value' of undefined
    at RichTextInput.componentDidMount 

If a add the input props with arbitrary value, it's working.

 <RichTextInput {...props} source="description" addLabel={true} input={{"value":"<b>Test</b>"}} />

I'm really lost ! Thank's for your help.

Nico (Noob on ReactJS)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.