marklogic-community / grove-cli Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 1.0 220 KB

License: Other

JavaScript 100.00%

grove-cli's People

Contributors

Stargazers

Watchers

Forkers

crism

grove-cli's Issues

Add option for Node or Spring Boot middle-tier

Let's let the user decide which middle their they want to use - Node or Spring boot.

Prototype Pollution in minimist

Potential security problem reported by GitHub.

How To Deploy Production app

I am currently trying to deploy the front/backend code and having a hard time understanding how to deploy the dist and configuring the proxy for fetch? The documentation is sparse to describe how to configure the proxy for /api calls

Migrate to Github

check and resolve pending PR's
import from internal bitbucket to github
add deprecation message to bitbucket
migrate unresolved PR's
prune unnecessary branches
check README, package*, NOTICE/LICENSE
republish under @marklogic-community?

Npm pointing at wrong repository

Current package.json lists the wrong repository:

"repository": "https://project.marklogic.com/repo/users/pmcelwee/repos/grove-cli/browse",

Should instead use github @marklogic-community/grove-cli

"repository": "https://github.com/marklogic-community/grove-cli.git"

Release as 1.0.0.-rc.2

grove -V prints incorrect version

Currently index.js lists the version as 0.1.0. This should be updated. Perhaps it can read the package.json and return the version found there instead of keeping its own copy.

Automatic update check

The slush-ml-node template had code to compare version on npm against local version, and warn if there was an update. Wondering if we should have something similar for grove-cli and/or the templates. Then again, you don't have to install them locally, except for cli. Could still be useful though..

Search/replace properties in template code

Slush-marklogic-node used to do a search/replace for @app-name and a few other properties. We need the same kind of functionality in grove-cli as well.

check node version and abort if < 8.10.0

testing pmcelwee$ nvm use 6.11
Now using node v6.11.0 (npm v5.5.1)
testing pmcelwee$ grove new test-old-node
-bash: grove: command not found
testing pmcelwee$ npm install -g @marklogic-community/grove-cli
/Users/pmcelwee/.nvm/versions/node/v6.11.0/bin/grove -> /Users/pmcelwee/.nvm/versions/node/v6.11.0/lib/node_modules/@marklogic-community/grove-cli/index.js
+ @marklogic-community/[email protected]
added 78 packages in 13.266s
testing pmcelwee$ grove new test-old-node
? Please confirm the name of your new project test-old-node
? Do you want to create your Grove project with the React or the Vue UI? React

Generating a Grove Project named "test-old-node" using the Grove React UI, the Grove Node middle-tier, and ml-gradle...
Cloning into 'test-old-node'...
Submodule 'marklogic' (https://project.marklogic.com/repo/scm/~gjosten/grove-ml-gradle.git) registered for path 'marklogic'
Submodule 'server' (https://project.marklogic.com/repo/scm/nacw/grove-node.git) registered for path 'middle-tier'
Submodule 'ui' (https://project.marklogic.com/repo/scm/~pmcelwee/grove-react-ui.git) registered for path 'ui'
Cloning into '/Users/pmcelwee/work/dev/grove/testing/test-old-node/marklogic'...
Cloning into '/Users/pmcelwee/work/dev/grove/testing/test-old-node/middle-tier'...
Cloning into '/Users/pmcelwee/work/dev/grove/testing/test-old-node/ui'...
Initialized a new git repository

2019-05-13T15:08:23.640Z error: util.promisify is not a function
TypeError: util.promisify is not a function
    at read (/Users/pmcelwee/.nvm/versions/node/v6.11.0/lib/node_modules/@marklogic-community/grove-cli/src/managers/config/grove-node.js:52:6)
    at Object.merge (/Users/pmcelwee/.nvm/versions/node/v6.11.0/lib/node_modules/@marklogic-community/grove-cli/src/managers/config/grove-node.js:63:10)
    at identifyTemplate.then.template (/Users/pmcelwee/.nvm/versions/node/v6.11.0/lib/node_modules/@marklogic-community/grove-cli/src/createNew.js:196:52)
    at process._tickCallback (internal/process/next_tick.js:109:7)`
testing pmcelwee$
``

Creates projects using wrong version of templates

createNew.js is pointing at two old template repositories.

React and Vue templates are part of @marklogic-community

React: https://github.com/marklogic-community/grove-react-template.git

Vue: https://github.com/marklogic-community/grove-vue-template.git