marklieberman / youtube-dl-button Goto Github PK

There is a problem where youtube-dl appears to hang when invoked using Process.Start, as if waiting for input or blocking on pipe IO. I haven't been able to identify a reason but the problem is greatly reduced just by adding a delay as in https://github.com/marklieberman/youtube-dl-button/blob/master/native-app/Program.cs#L147.

ain't gonna write code for it, but in general :
different fields for youtube-dl arguements, for video and audio, instead of 1 field that goes for both of them.
option to choose a converted format in case the found format isn't the same one (lets say mp4 is the best video and the converted format chose by the user is mkv, so converting the mp4 to mkv).
add metadata option (--add-metadata).
if you ask me, the options default formats and quick download audio formats should be removed, youtube-dl 2 fields (audio and video), and naming the file is whats important, all the other options should be placed as check boxes.

other stuff :
playlists get downloaded in folders.
an option to open the options page from firefox directly from the addon.
add whether to embed thumbnail or not (--embed-thumbnail) specifically to audio.
if file exist ask if to overwrite, also a checkbox in the settings page if whether to overwrite automatically or not or ask everytime (not checked (not filled), checked (v), ask everytime (filled, looks like a filled black square inside the checkbox)).

also add open windows folder or open file if possible

great addon.

Save the values input into the popup. The values should be saved per-domain.

All jobs run simultaneously. There should be an option to limit the number of concurrent jobs.

When I download a video from YouTube, the item always says "Waiting…" and doesn't seem to ever finish. I've tried setting the youtube-dl path both to the folder that youtube-dl.exe is in and the absolute file path for the file itself. Also made sure that ffmpeg was installed and part of the PATH.

Where can i get it?