Coder Social home page Coder Social logo

Comments (3)

mjordan avatar mjordan commented on May 24, 2024

Maybe putting this check, and the others for URLs, etc., in src/config/Config.php is a better place, since the tests are against configuration information. Also, MIK instantiates a config object earlier than it instantiates a fetcher. Any objections to putting them there?

from mik.

MarcusBarnes avatar MarcusBarnes commented on May 24, 2024

I have no objections to this.

from mik.

mjordan avatar mjordan commented on May 24, 2024

Options to check mappings snippets, URLs, and file paths are in place. If an .ini option ends in '_url', that value is checked; if it ends in '_path' or '_directory', the value is checked. I decided to make checking a separate, preliminary step to running mik to perform the conversion and have documented the workflow in the README.

I can merge the feature branch (issue-43) into master whenever is convenient.

from mik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.