Make HTTP requests more robusts against network connectivity and latency issues about mik

[mjordan]

Guzzle has a component called Retry-Subscriber (https://github.com/guzzle/retry-subscriber) that looks like it should be useful. Can be installed via composer.

[mjordan]

First implementation in 81b6eea.

[mjordan]

We should implement Guzzle in the other filegetters, in order to mitigate against slow response times on the CONTENTdm server due to backup jobs, etc. I can do the CdmNewspapers filegetter if you want.

[MarcusBarnes]

That would be great. Thank you.

[mjordan]

@MarcusBarnes can you take a look to make sure that how I've implemented error catching in https://github.com/MarcusBarnes/mik/blob/issue-3/src/filegetters/CdmNewspapers.php#L107 (and similar at lines 220, 252, 277)?

[mjordan]

@MarcusBarnes I've added logging to the Guzzle calls. Take a quick look? https://github.com/MarcusBarnes/mik/blob/issue-3/src/filegetters/CdmNewspapers.php#L115

I tested by turning off my network connection half way through a job. Pointers showed up in problem_records.log and Guzzle errors showed up in mik.log.

[MarcusBarnes]

👍 Tested with a CT SpecificSet batch. It appears to function as expected. When I disconnected the network, the pointers showed up in problme_records.log and the Guzzle errors were recorded in the mik.log. Thank you @mjordan for your work on this.

[mjordan]

Great, thanks. I'll incorporate this into the CdmSingleFile filegetter as well.

[MarcusBarnes]

@mjordan That would be awesome. Thank you.

[mjordan]

Done in 169597c. I think we can merge issue-3 into master and close this issue. @MarcusBarnes any reason not to do that?

[mjordan]

... and now CdmPhpDocuments is done.

[MarcusBarnes]

@mjordan Thank you. I don't see any reason to not to merge. I'll double check and then go ahead if everything looks good. Thanks again for the contribution.

[mjordan]

Merged into master.