marcstraube / foundryvtt-scenery Goto Github PK

Is your feature request related to a problem? Please describe.
I want the module to record Wall/Light/Sound/Tiles for each entry. So, you can add to the first entry a group of Wall/Light/Sound/Tiles, then, add to a second entry a different set of Wall/Light/Sound/Tiles.

Does it work in v11? Any plan to upgrade to v11?

When trying to access the main Scenery menu, I can only get to it via the top scene navigation. The Scenery option is still available in the scene directory, but doesn't do anything.

Describe the bug
You can't scan without remove the filename.

To Reproduce

1. I select the first file.
2. Click scan
3. It will not show the other files

I can make it work by

1. I remove the file name leaving only the path
2. I click scan
3. It show all files.
4. But, it start to generate an error about wrong default file
   

Expected behavior
I want to insert the Default file and scan.

Screenshots

System information (please complete the following information):

• Scenery Version: 112
• FoundryVTT Version: 10291
• Browser: chrome
• FoundryVTT Game System and Version: swade last

Describe the bug
When you click the preview button in the Scenery scene configuration window, a preview window will open, even if no URL is given.

To Reproduce
Steps to reproduce the behavior:

1. Open a scenes Scenery configuration window
2. Add a new variation
3. Click on preview button
4. A preview window without an image will open

Expected behavior
If no URL is given, no preview window should open.

System information (please complete the following information):

• Scenery Version: 1.1.1
• FoundryVTT Version: 10.291
• Browser: electron
• FoundryVTT Game System and Version: dnd5e 2.1.2, pf2e 4.6.8

Show the number of map variants on the preview image inside the Scenes tab.
Make it an configurable option to show this additional info.

Describe the bug
Scanning is not able to identify variations when the common part of the filename includes characters that will be URI-encoded.
This includes spaces, symbols, and non-English characters.

To Reproduce
Steps to reproduce the behavior:

1. Create two map files where one basename contains the other, but the name includes spaces.
   For example, "Forest Path.jpg" and "Forest Path Night.jpg".
2. Create a new scene using Forest Path as the background image.
3. Open the Scenery popup and scan for variations. Nothing is found.

Expected behavior
"Forest Path Night" should be identified as a variant.

System information (please complete the following information):

• Scenery Version: 1.1.3
• FoundryVTT Version: 11.315
• Browser: Firefox
• FoundryVTT Game System and Version: dnd5e 2.4.1

Additional context
FilePicker API returns URI-encoded paths. I will submit a PR to use decodeURI in the scan process.
Arguably it is good practice to use filenames that don't get encoded, but Foundry in general handles special characters without issue.

Maybe my misunderstanding of how the system works, but I added a second scene to test, changed views back and forward a few times, then tried to delete the second map.

However, nothing happens when you push delete, no errors, no effect, does not seem possible to delete a scene variation when added

I was not SHOWING the variation when testing, I had selected the original scene for GM and Player. No players were connected to the game at the time