Comments (4)
Static field with the key is a good idea, but I am skipping prefix because it is easy to replace with custom key and this is complicating both library and it's usage.
from activitystarter.
I am not sure if a field with the key should be public. Why? Are there any real use case when it is needed?
from activitystarter.
You can make it optional... for example access=PUBLIC
from activitystarter.
It won't change anything. The only reason I see that this keys could be useful is when the user needs to change how properties storage is working. And I think that it should never happen. It is because flow might change inside the library and when the developer changed it (for any reason) and then flow is changing then the user has a problem. Possibly he is even not the same developer then one who made a workaround in the first place. If there are any use-cases that need flow to be different then we should work on supporting them.
from activitystarter.
Related Issues (18)
- @Arg arguments HOT 3
- Replace @ActivityStarterConfig(converters = { ParcelarArgConverter.class }) to @Arg(bundler = ParcelarArgConverter.class) HOT 1
- How to parse list of enum? HOT 3
- Add Kotlin support HOT 1
- Crash on SupportFragment.onSaveInstanceState in Kotlin HOT 1
- MultiDex error
- Activity State not getting restored when the activity is killed and restored HOT 12
- Can't fetch data at HOT 2
- var ArrayList of Parcelable problem HOT 2
- Migration to androidx HOT 2
- Implement method .startActivityForResult HOT 5
- Incremental processor
- w: Runtime JAR files in the classpath should have the same version. HOT 5
- Still have NoSuchElementException in 1.12-beta2
- Crash when using Proguard
- Implement support for Parcels lib HOT 15
- Create any IntentBuilder to avoid generation of methods HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from activitystarter.