Implement support for Parcels lib about activitystarter

[MarcinMoskala]

@PingForward please check out version 0.70-beta.1
Changes to apply:

• There is no more dependency on the extra module. Parceler has now native support. You need to have a dependency to Parceler!
• Delete converter in configuration
• Change @arg to @arg(parceler = true) before any element that you want to wrap and unwrap by Parceler.

Please let me know if everything is ok.

[thats-bot]

Why you choose this way? I mean why you define ParcelarArgConverter.class as one global config for all activties and fragments?
Why not to use it for every specified argument? This way give much more flexibility to the user
@arg(bundler = ParcelerArgsBundler.class)

[MarcinMoskala]

I am using alternatives that are actually making your domain object Parcelable (like AutoParcel, PaperParcel or Smuggler) but if there is a need for that in the community then it might be added.

[Kolyall]

@MarcinMoskala https://github.com/johncarl81/parceler
this lib is really useful
But currently to use with your lib I need to make this:

MainActivityStarter.start(this,Parcels.wrap(mItem) );

public class MainActivity extends BaseActivity {
     @Arg Parcelable mItemParcelable;
     AnyItem mItem;

public void onCreate(Bundle bundle){
     super.onCreate(bundle);
     mItem = Parcels.unwrap(mItemParcelable);
}
}

[Kolyall]

if it's ready please update README, Thanks)

[thats-bot]

We really need the support for @Arg(bundler = ParcelerArgsBundler.class) parceler library.
Check how its implemented in fragmentargs

[MarcinMoskala]

After some analysis, I see two sensible options:
First is similar to what was implemented in fragmentargs, but it needs also a support for intent.

public class DateArgsBundler implements ArgsBundler<Date>{

    @Override public void put(String key, Date value, Bundle bundle) {
        bundle.putLong(key, value.getTime());
    }

    @Override public void put(String key, Date value, Intent intent) {
        intent.putLongExtra(key, value.getTime());
    }

    @Override public Date get(String key, Bundle bundle) {       
        long timestamp = bundle.getLong(key);
        return new Date(timestamp);
    }

    @Override public Date get(String key, Intent intent) {       
        long timestamp = intent.getLongExtra(key);
        return new Date(timestamp);
    }
}

Example usage:

@Arg(parcelar = DateArgsBundler) Date date;

The second option (much more difficult to implement) is to always change the type from not served to some served. For example:

public class DateTransformation implements ArgsTransformation<Date, Long>{

    @Override public Long pack(Date value) {
        return value.getTime()
    }

    @Override public Date unpack(Long timestamp) {
        return new Date(timestamp);
    }
}

Usage is the same. It would be also safer because the library is handling all other operations. But also much harder to implement.

What do you think about it? @Kolyall @PingForward

[Kolyall]

@MarcinMoskala I haven't experience on it

[thats-bot]

@MarcinMoskala
I don't think we need something special like the second variant in first version of the lib.
But its a good idea to encapsulate all get/put methods it parent interface/class.

[MarcinMoskala]

Here is beta:
https://github.com/MarcinMoskala/ActivityStarter/tree/Introduce_arg_wrappers

[MarcinMoskala]

🍾 Converters functionality is done 🍾
Here is wiki. It would be nice to have some feedback :)
@Kolyall @PingForward

[Kolyall]

@MarcinMoskala Thanks, it's great
But for what implements IsParcel is needed? Can you remove it?

[MarcinMoskala]

I could but there should be some distinction to allow to introduce other converters that are converting from Object type. If you want to avoid it then define just:

public class ParcelarArgConverter implements ArgConverter<Object, Parcelable> {

    @Override
    public Parcelable wrap(Object toWrap) {
        return Parcels.wrap(toWrap);
    }

    @Override
    public Object unwrap(Parcelable wrapped) {
        return Parcels.unwrap(wrapped);
    }
}

And define it as an converter:

@ActivityStarterConfig(converters = { ParcelarArgConverter.class })

[Kolyall]

@PingForward @MarcinMoskala I approve that @ActivityStarterConfig(converters = { ParcelarArgConverter.class }) should be replaced to @Arg(bundler = ParcelerArgsBundler.class) for each field variable

[Kolyall]

@MarcinMoskala Great, cool!!! It works!